From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Olof Johansson <olof@lixom.net>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH 1/5] x86: efi: refactor efi_init() a bit
Date: Thu, 5 Jan 2012 18:17:24 +0000 [thread overview]
Message-ID: <20120105181723.GA24242@srcf.ucam.org> (raw)
In-Reply-To: <1325610682-24811-2-git-send-email-olof@lixom.net>
On Tue, Jan 03, 2012 at 09:11:18AM -0800, Olof Johansson wrote:
> if (memmap.desc_size != sizeof(efi_memory_desc_t))
> - printk(KERN_WARNING
> - "Kernel-defined memdesc doesn't match the one from EFI!\n");
> + printk(KERN_WARNING "Kernel-defined memdesc doesn't match the "
> + "one from EFI!\n");
Just kill this - it's valid per-spec, there's no reason for us to
complain.
Looks fine otherwise.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-01-05 18:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 17:11 [PATCH v3 0/5] x86: efi: cleanups and basic 32/64 bit support Olof Johansson
2012-01-03 17:11 ` [PATCH 1/5] x86: efi: refactor efi_init() a bit Olof Johansson
2012-01-05 11:22 ` Matt Fleming
2012-01-05 17:49 ` Olof Johansson
2012-01-05 18:17 ` Matthew Garrett [this message]
2012-01-05 21:00 ` Olof Johansson
2012-01-03 17:11 ` [PATCH 2/5] x86: efi: convert printk to pr_*() Olof Johansson
2012-01-04 5:26 ` Joe Perches
2012-01-05 17:17 ` Olof Johansson
2012-01-03 17:11 ` [PATCH 3/5] x86: efi: cleanup config table walking Olof Johansson
2012-01-05 11:22 ` Matt Fleming
2012-01-03 17:11 ` [PATCH 4/5] x86: efi: add basic error handling Olof Johansson
2012-01-05 11:21 ` Matt Fleming
2012-01-05 17:52 ` Olof Johansson
2012-01-05 21:02 ` Olof Johansson
2012-01-03 17:11 ` [PATCH 5/5] x86: efi: allow basic init with mixed 32/64-bit efi/kernel Olof Johansson
2012-01-05 11:21 ` Matt Fleming
2012-01-05 17:53 ` Olof Johansson
2012-01-05 18:21 ` Matthew Garrett
2012-01-05 20:59 ` Olof Johansson
2012-01-05 21:02 ` [PATCH v4 0/5] x86: efi: cleanups and basic 32/64 bit support Olof Johansson
2012-01-05 21:02 ` [PATCH 1/5] x86: efi: refactor efi_init() a bit Olof Johansson
2012-01-05 21:02 ` [PATCH 2/5] x86: efi: convert printk to pr_*() Olof Johansson
2012-01-05 21:02 ` [PATCH 3/5] x86: efi: cleanup config table walking Olof Johansson
2012-01-05 21:02 ` [PATCH 4/5] x86: efi: add basic error handling Olof Johansson
2012-01-05 21:02 ` [PATCH 5/5] x86: efi: allow basic init with mixed 32/64-bit efi/kernel Olof Johansson
2012-02-08 0:25 [PATCH v4 0/5] [RESEND] x86: efi: cleanups and basic 32/64-bit support Olof Johansson
2012-02-08 0:25 ` [PATCH 1/5] x86: efi: refactor efi_init() a bit Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105181723.GA24242@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@elte.hu \
--cc=olof@lixom.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome