From: Andi Kleen <andi@firstfloor.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org
Subject: Re: x86-64: memset()/memcpy() not fully standards compliant
Date: Thu, 5 Jan 2012 19:28:46 +0100 [thread overview]
Message-ID: <20120105182846.GQ11715@one.firstfloor.org> (raw)
In-Reply-To: <4F05BBFE020000780006A983@nat28.tlf.novell.com>
On Thu, Jan 05, 2012 at 02:04:30PM +0000, Jan Beulich wrote:
> Forever these two functions have been limited to deal with at most 4G
> at a time. While I cannot point out an in-tree user that would require
> larger sizes, it is now the second time that within our Xen kernel we got
> bitten by that limitation. Would you nevertheless accept a patch to
> eliminate those shortcomings (iirc there may need to be workarounds
> for CPU bugs when it comes to using string instructions on such large
> blocks, albeit memmove() doesn't seem to care)?
>
> Otherwise, is there any rationale for this sort of lurking bug?
Most (all?) of the CPUs I cared about when writing that code had
bugs with string instructions and >4GB.
And I don't think anything in the kernel would ever process that big
areas in a single operation.
So it never seemed worth caring about.
You probably would need at least one more CMP & conditional jump
in the hot path, so everyone would pay for something that never happens.
-Andi
next prev parent reply other threads:[~2012-01-05 18:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 14:04 Jan Beulich
2012-01-05 15:27 ` hpanvin@gmail.com
2012-01-05 18:28 ` Andi Kleen [this message]
2012-01-05 23:22 ` H. Peter Anvin
2012-01-06 1:47 ` Andi Kleen
2012-01-06 2:03 ` H. Peter Anvin
2012-01-06 7:22 ` Jan Beulich
2012-01-06 9:49 ` Andi Kleen
2012-01-06 10:22 ` Jan Beulich
2012-01-06 10:37 ` Andi Kleen
2012-01-06 10:50 ` Jan Beulich
2012-01-06 11:08 ` Andi Kleen
2012-01-06 12:25 ` Jan Beulich
2012-01-06 19:44 ` Andi Kleen
2012-01-06 23:12 ` H. Peter Anvin
2012-01-06 11:08 ` Ingo Molnar
2012-01-06 20:40 ` Valdis.Kletnieks
2012-01-09 8:29 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105182846.GQ11715@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=JBeulich@suse.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome