From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030613Ab2AFVO1 (ORCPT ); Fri, 6 Jan 2012 16:14:27 -0500 Received: from mail-fx0-f74.google.com ([209.85.161.74]:33723 "EHLO mail-fx0-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759234Ab2AFVO0 (ORCPT ); Fri, 6 Jan 2012 16:14:26 -0500 To: Glauber Costa CC: davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, cgroups@vger.kernel.org, Greg Thelen , Hiroyouki Kamezawa , Laurent Chavey Subject: Re: [PATCH] net: fix sock_clone reference mismatch with tcp memcontrol Message-Id: <20120106211423.967A716F64A@chavey.mtv.corp.google.com> Date: Fri, 6 Jan 2012 13:14:23 -0800 (PST) From: chavey@google.com (Laurent Chavey) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Sockets can also be created through sock_clone. Because it copies > all data in the sock structure, it also copies the memcg-related pointer, > and all should be fine. However, since we now use reference counts in > socket creation, we are left with some sockets that have no reference > counts. It matters when we destroy them, since it leads to a mismatch. > > Signed-off-by: Glauber Costa > CC: David S. Miller > CC: Greg Thelen > CC: Hiroyouki Kamezawa > CC: Laurent Chavey > > --- Tested-by: Laurent Chavey