From: David Miller <davem@davemloft.net>
To: cesarb@cesarb.net
Cc: florian@openwrt.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] r6040: fix typo in use of MCR0 register bits
Date: Sat, 07 Jan 2012 12:09:47 -0800 (PST) [thread overview]
Message-ID: <20120107.120947.1387951434734479835.davem@davemloft.net> (raw)
In-Reply-To: <1325949197-10143-1-git-send-email-cesarb@cesarb.net>
From: Cesar Eduardo Barros <cesarb@cesarb.net>
Date: Sat, 7 Jan 2012 13:13:17 -0200
> Commit 4e16d6ebd65b4f2c4e3f780b4c5704beef64019c (r6040: define more MCR0
> register bits) added #define values for MCR0 register bits and converted
> uses of hardcoded magic values to uses of these defines.
>
> However, one of the conversions looks suspicious:
>
> #define MCR0 0x00 /* Control register 0 */
> +#define MCR0_RCVEN 0x0002 /* Receive enable */
> +#define MCR0_XMTEN 0x1000 /* Transmission enable */
>
> /* Init RDC private data */
> - lp->mcr0 = 0x1002;
> + lp->mcr0 = MCR0_XMTEN | MCR0;
>
> I believe what was meant here was MCR0_XMTEN | MCR0_RCVEN, which makes
> sense and matches the original values.
>
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
Good catch, applied, thanks a lot.
next prev parent reply other threads:[~2012-01-07 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 15:13 Cesar Eduardo Barros
2012-01-07 20:09 ` David Miller [this message]
2012-01-09 10:15 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120107.120947.1387951434734479835.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cesarb@cesarb.net \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®