From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 0/6 v3] [GIT PULL] x86: Workaround for NMI iret woes
Date: Sun, 8 Jan 2012 09:48:44 +0100 [thread overview]
Message-ID: <20120108084844.GA7168@elte.hu> (raw)
In-Reply-To: <20111222031357.120841629@goodmis.org>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Ingo,
>
> I updated the patches to reflect your comments and ran them through
> all my tests again. Below is the full diff between v2 and v3.
>
> I renamed nmi_preprocess() and nmi_postprocess() to
> nmi_nesting_preprocess() and nmi_nesting_postprocess() to at least
> note that this has to do with nmi nesting. I also commented the
> fact that i386 may loop back to the preprocess.
>
> I had to move the debug_usage functions to debugreg.h, because
> smp.h includes processor.h where making the inc/dec inline
> caused include header issues.
>
> -- Steve
>
> Please pull the latest tip/x86/core-3 tree, which can be found at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> tip/x86/core-3
>
> Head SHA1: 42181186ad4db986fcaa40ca95c6e407e9e79372
>
>
> Linus Torvalds (1):
> x86: Do not schedule while still in NMI context
>
> Steven Rostedt (5):
> x86: Document the NMI handler about not using paranoid_exit
> x86: Add workaround to NMI iret woes
> x86: Keep current stack in NMI breakpoints
> x86: Allow NMIs to hit breakpoints in i386
> x86: Add counter when debug stack is used with interrupts enabled
>
> ----
> arch/x86/include/asm/debugreg.h | 22 ++++
> arch/x86/include/asm/desc.h | 12 ++
> arch/x86/kernel/cpu/common.c | 24 +++++
> arch/x86/kernel/entry_64.S | 218 +++++++++++++++++++++++++++++++++------
> arch/x86/kernel/head_64.S | 4 +
> arch/x86/kernel/nmi.c | 102 ++++++++++++++++++
> arch/x86/kernel/traps.c | 20 ++++
> 7 files changed, 369 insertions(+), 33 deletions(-)
Pulled, thanks a lot Steve! I've ran 500 randconfig iterations
and these bits seem fine.
Thanks,
Ingo
prev parent reply other threads:[~2012-01-08 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 3:13 Steven Rostedt
2011-12-22 3:13 ` [PATCH 1/6 v3] x86: Do not schedule while still in NMI context Steven Rostedt
2011-12-22 3:13 ` [PATCH 2/6 v3] x86: Document the NMI handler about not using paranoid_exit Steven Rostedt
2011-12-22 3:14 ` [PATCH 3/6 v3] x86: Add workaround to NMI iret woes Steven Rostedt
2011-12-22 3:14 ` [PATCH 4/6 v3] x86: Keep current stack in NMI breakpoints Steven Rostedt
2011-12-22 3:14 ` [PATCH 5/6 v3] x86: Allow NMIs to hit breakpoints in i386 Steven Rostedt
2011-12-22 3:14 ` [PATCH 6/6 v3] x86: Add counter when debug stack is used with interrupts enabled Steven Rostedt
2012-01-08 8:48 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120108084844.GA7168@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome