mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sangbeom Kim <sbkim73@samsung.com>
Cc: lrg@ti.com, sameo@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] regulator: Add S5M8767A regulator driver
Date: Sun, 8 Jan 2012 23:25:15 -0800	[thread overview]
Message-ID: <20120109072515.GE22134@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1325225153-32389-1-git-send-email-sbkim73@samsung.com>

On Fri, Dec 30, 2011 at 03:05:53PM +0900, Sangbeom Kim wrote:

Ah, I knew there was a reason why I hadn't reviewed this!  I was
expecting a new version with these:

> +static int s5m8767_reg_enable_suspend(struct regulator_dev *rdev)
> +static int s5m8767_reg_disable_suspend(struct regulator_dev *rdev)

removed.  Otherwise this looks good.

  parent reply	other threads:[~2012-01-09  7:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-30  6:05 Sangbeom Kim
2012-01-08 23:16 ` Samuel Ortiz
2012-01-09  6:47   ` Mark Brown
2012-01-09  9:08     ` Samuel Ortiz
2012-01-09 21:37       ` Mark Brown
2012-01-09 23:43         ` Samuel Ortiz
2012-01-09  7:25 ` Mark Brown [this message]
2012-01-09  8:35   ` Sangbeom Kim
2012-01-09  8:41     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120109072515.GE22134@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=sameo@linux.intel.com \
    --cc=sbkim73@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome