From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755596Ab2AIJD3 (ORCPT ); Mon, 9 Jan 2012 04:03:29 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:49471 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755262Ab2AIJDZ (ORCPT ); Mon, 9 Jan 2012 04:03:25 -0500 Date: Mon, 9 Jan 2012 10:03:12 +0100 From: Thierry Reding To: "Cousson, Benoit" Cc: devicetree-discuss@lists.ozlabs.org, Tony Lindgren , Catalin Marinas , Daniel Walker , Russell King , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , David Brown , "open list:ARM/QUALCOMM MSM..." , Rob Herring , Barry Song , Thomas Gleixner , open list: OMAP SUPPORT , Andrew Victor , "open list:ARM/ATMEL AT91RM9..." , open list , Bryan Huntsman , Richard Zhao , Sascha Hauer , David Woodhouse , ; Illegal-Object: Syntax error in Cc: address found on vger.kernel.org: Cc: ; ^-missing semicolon to end mail group, extraneous tokens in mailbox, missing end of mailbox Subject: Re: [PATCH] irqdomain: Initialize number of IRQs for simple domains Message-ID: <20120109090311.GA10040@avionic-0098.mockup.avionic-design.de> References: <1325860112-22051-1-git-send-email-thierry.reding@avionic-design.de> <4F072843.6050306@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <4F072843.6050306@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Provags-ID: V02:K0:z0np+h7p+A5hCtZfQTB8UJ0EXtLxXQIF6D1RAtYZ7RM o+6NnJ6qnra1YfDjkv6ZNVAmcaNLR6Uk0e6esBsPRZ9QbNdfry 5Rwngy9wikbVuycDNrOCqjfxs1c7TjDjmd8z0vr2IfeTClMD2r ZQsHoEFtUtdueT/vbyE5EmrF/lyMXLLY5OEIYc8f+MM6ypQ2GU NPvTRM/yxuHD/54A/u8e8e7W9GC3F02NbmJpTLMf+9bUDanmpG pSusfE5dSj6xSoRNRQ/fmYo43NY+MlkdEY4dzGgkW3P2SCbchp sj4pFc/F+igYln55SXQb0eW5ZB/x8KtELAdmefY10fVVnNoJbV H0BIPYgPzhZExHI0m+M693xdpdvYvpMs+UByzur50cVl5THP7Q TMgUOXXZ8avzVQ0DNrvuZt0z+1RPXsU1BE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Cousson, Benoit wrote: > Hi Thierry, >=20 > On 1/6/2012 3:28 PM, Thierry Reding wrote: > >The irq_domain_add() function needs the number of interrupts in the > >domain to properly initialize them. In addition the allocated domain > >is now returned by the irq_domain_{add,generate}_simple() helpers. >=20 > [...] >=20 > >diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/b= oard-generic.c > >index d587560..bf67781 100644 > >--- a/arch/arm/mach-omap2/board-generic.c > >+++ b/arch/arm/mach-omap2/board-generic.c > >@@ -66,8 +66,11 @@ static struct of_device_id intc_match[] __initdata = =3D { > > static void __init omap_generic_init(void) > > { > > struct device_node *node =3D of_find_matching_node(NULL, intc_match); > >- if (node) > >- irq_domain_add_simple(node, 0); > >+ if (node) { > >+ struct irq_domain *domain; > >+ domain =3D irq_domain_add_simple(node, 0, INTCPS_NR_IRQS); >=20 > The number of interrupts will depend on the OMAP generation. That > one is just valid for the 3430 INTC controller. > Since the previous code was using zero, I guess that using 0 there > should be fine. >=20 > Moreover, that piece of code should not exist anymore on 3.3 if the > series I sent last month to leverage Rob's DT interrupt init is > merged [1]. >=20 > I've just ping Rob and Grant on that series to get a status. Okay, so I guess we should wait for you patch to go in first and I'll update this patch on top of that. I assume we can coordinate things in linux-next? Thierry --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8KrU8ACgkQZ+BJyKLjJp+TRgCfZOrAsza8BDBWyon6uCOjTrsW V6IAnjIkRPQSQTh5AThunw4n4ZK1La8m =eQ7B -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--