From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk, Ramkrishna Vepa <ram.vepa@qlogic.com>,
Mike Marciniszyn <mike.marciniszyn@qlogic.com>,
Roland Dreier <roland@purestorage.com>
Subject: [12/40] IB/qib: Fix a possible data corruption when receiving packets
Date: Tue, 10 Jan 2012 13:45:25 -0800 [thread overview]
Message-ID: <20120110214619.252095189@clark.kroah.org> (raw)
In-Reply-To: <20120110214630.GA14384@kroah.com>
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ram Vepa <ram.vepa@qlogic.com>
commit eddfb675256f49d14e8c5763098afe3eb2c93701 upstream.
Prevent a receive data corruption by ensuring that the write to update
the rcvhdrheadn register to generate an interrupt is at the very end
of the receive processing.
Signed-off-by: Ramkrishna Vepa <ram.vepa@qlogic.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@qlogic.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/infiniband/hw/qib/qib_iba6120.c | 4 +++-
drivers/infiniband/hw/qib/qib_iba7220.c | 4 +++-
drivers/infiniband/hw/qib/qib_iba7322.c | 6 ++++--
3 files changed, 10 insertions(+), 4 deletions(-)
--- a/drivers/infiniband/hw/qib/qib_iba6120.c
+++ b/drivers/infiniband/hw/qib/qib_iba6120.c
@@ -2076,9 +2076,11 @@ static void qib_6120_config_ctxts(struct
static void qib_update_6120_usrhead(struct qib_ctxtdata *rcd, u64 hd,
u32 updegr, u32 egrhd, u32 npkts)
{
- qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
if (updegr)
qib_write_ureg(rcd->dd, ur_rcvegrindexhead, egrhd, rcd->ctxt);
+ mmiowb();
+ qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
+ mmiowb();
}
static u32 qib_6120_hdrqempty(struct qib_ctxtdata *rcd)
--- a/drivers/infiniband/hw/qib/qib_iba7220.c
+++ b/drivers/infiniband/hw/qib/qib_iba7220.c
@@ -2704,9 +2704,11 @@ static int qib_7220_set_loopback(struct
static void qib_update_7220_usrhead(struct qib_ctxtdata *rcd, u64 hd,
u32 updegr, u32 egrhd, u32 npkts)
{
- qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
if (updegr)
qib_write_ureg(rcd->dd, ur_rcvegrindexhead, egrhd, rcd->ctxt);
+ mmiowb();
+ qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
+ mmiowb();
}
static u32 qib_7220_hdrqempty(struct qib_ctxtdata *rcd)
--- a/drivers/infiniband/hw/qib/qib_iba7322.c
+++ b/drivers/infiniband/hw/qib/qib_iba7322.c
@@ -4060,10 +4060,12 @@ static void qib_update_7322_usrhead(stru
*/
if (hd >> IBA7322_HDRHEAD_PKTINT_SHIFT)
adjust_rcv_timeout(rcd, npkts);
- qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
- qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
if (updegr)
qib_write_ureg(rcd->dd, ur_rcvegrindexhead, egrhd, rcd->ctxt);
+ mmiowb();
+ qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
+ qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
+ mmiowb();
}
static u32 qib_7322_hdrqempty(struct qib_ctxtdata *rcd)
next prev parent reply other threads:[~2012-01-10 22:59 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 21:46 [00/40] 3.0.17-stable review Greg KH
2012-01-10 21:45 ` [01/40] MAINTAINERS: stable: Update address Greg KH
2012-01-10 21:45 ` [02/40] Documentation: Update stable address Greg KH
2012-01-10 21:45 ` [03/40] firmware: Fix an oops on reading fw_priv->fw in sysfs loading file Greg KH
2012-01-10 21:45 ` [04/40] rt2800usb: Move ID out of unknown Greg KH
2012-01-10 21:45 ` [05/40] offb: Fix setting of the pseudo-palette for >8bpp Greg KH
2012-01-10 21:45 ` [06/40] offb: Fix bug in calculating requested vram size Greg KH
2012-01-10 21:45 ` [07/40] wl12xx: Validate FEM index from ini file and FW Greg KH
2012-01-10 21:45 ` [08/40] wl12xx: Check buffer bound when processing nvs data Greg KH
2012-01-10 21:45 ` [09/40] powerpc/time: Handle wrapping of decrementer Greg KH
2012-01-10 21:45 ` [10/40] powerpc: Fix unpaired probe_hcall_entry and probe_hcall_exit Greg KH
2012-01-10 21:45 ` [11/40] asix: new device id Greg KH
2012-01-10 21:45 ` Greg KH [this message]
2012-01-10 21:45 ` [13/40] perf: Fix parsing of __print_flags() in TP_printk() Greg KH
2012-01-10 21:45 ` [14/40] reiserfs: Fix quota mount option parsing Greg KH
2012-01-10 21:45 ` [15/40] reiserfs: Force inode evictions before umount to avoid crash Greg KH
2012-01-10 21:45 ` [16/40] ext3: Dont warn from writepage when readonly inode is spotted after error Greg KH
2012-01-10 21:45 ` [17/40] USB: update documentation for usbmon Greg KH
2012-01-10 21:45 ` [18/40] atmel_serial: fix spinlock lockup in RS485 code Greg KH
2012-01-10 21:45 ` [19/40] cgroup: fix to allow mounting a hierarchy by name Greg KH
2012-01-10 21:45 ` [20/40] udf: Fix deadlock when converting file from in-ICB one to normal one Greg KH
2012-01-10 21:45 ` [21/40] drivers/usb/class/cdc-acm.c: clear dangling pointer Greg KH
2012-01-10 21:45 ` [22/40] USB: isight: fix kernel bug when loading firmware Greg KH
2012-01-10 21:45 ` [23/40] usb: usb-storage doesnt support dynamic id currently, the patch disables the feature to fix an oops Greg KH
2012-01-10 21:45 ` [24/40] USB: add quirk for another camera Greg KH
2012-01-10 21:45 ` [25/40] usb: musb: fix pm_runtime mismatch Greg KH
2012-01-10 21:45 ` [26/40] USB: omninet: fix write_room Greg KH
2012-01-10 21:45 ` [27/40] USB: Add USB-ID for Multiplex RC serial adapter to cp210x.c Greg KH
2012-01-10 21:45 ` [28/40] usb: fix number of mapped SG DMA entries Greg KH
2012-01-10 21:45 ` [29/40] xhci: Properly handle COMP_2ND_BW_ERR Greg KH
2012-01-10 21:45 ` [30/40] USB: option: add id for 3G dongle Model VT1000 of Viettel Greg KH
2012-01-10 21:45 ` [31/40] usb: option: add ZD Incorporated HSPA modem Greg KH
2012-01-10 21:45 ` [32/40] usb: ch9: fix up MaxStreams helper Greg KH
2012-01-10 21:45 ` [33/40] OHCI: final fix for NVIDIA problems (I hope) Greg KH
2012-01-10 21:45 ` [34/40] igmp: Avoid zero delay when receiving odd mixture of IGMP queries Greg KH
2012-01-10 21:45 ` [35/40] asix: fix infinite loop in rx_fixup() Greg KH
2012-01-10 21:45 ` [36/40] bonding: fix error handling if slave is busy (v2) Greg KH
2012-01-10 21:45 ` [37/40] PM / Sleep: Fix race between CPU hotplug and freezer Greg KH
2012-01-10 21:45 ` [38/40] SCSI: mpt2sas: Added missing mpt2sas_base_detach call from scsih_remove context Greg KH
2012-01-10 21:45 ` [39/40] usb: cdc-acm: Fix acm_tty_hangup() vs. acm_tty_close() race Greg KH
2012-01-10 21:45 ` [40/40] xfs: fix acl count validation in xfs_acl_from_disk() Greg KH
2012-01-11 22:21 ` [00/40] 3.0.17-stable review Nick Bowler
2012-01-12 23:01 ` Greg KH
2012-01-12 23:15 ` David Miller
2012-01-17 17:47 ` Greg KH
2012-01-26 18:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110214619.252095189@clark.kroah.org \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.marciniszyn@qlogic.com \
--cc=ram.vepa@qlogic.com \
--cc=roland@purestorage.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®