From: David Miller <davem@davemloft.net>
To: alex.shi@intel.com
Cc: kaber@trash.net, eric.dumazet@gmail.com, cl@gentwo.org,
tj@kernel.org, linux-kernel@vger.kernel.org,
ying.huang@intel.com, tglx@linutronix.de, mingo@redhat.com,
avi@redhat.com, akpm@linux-foundation.org,
a.p.zijlstra@chello.nl, kvm@vger.kernel.org,
jeremy@xensource.com
Subject: Re: [PATCH 1/3] net: use this_cpu_xxx replace percpu_xxx funcs
Date: Wed, 11 Jan 2012 01:03:31 -0800 (PST) [thread overview]
Message-ID: <20120111.010331.2039534822545257440.davem@davemloft.net> (raw)
In-Reply-To: <1326271533.5695.242.camel@debian>
From: "Alex,Shi" <alex.shi@intel.com>
Date: Wed, 11 Jan 2012 16:45:33 +0800
>> >>>> percpu_xxx funcs are duplicated with this_cpu_xxx funcs, so replace them
>> >>>> for further code clean up.
>> >>>>
>> >>>> And in preempt safe scenario, __this_cpu_xxx funcs has a bit better
>> >>>> performance since __this_cpu_xxx has no redundant preempt_disable()
>> >>>>
>> >>>> Signed-off-by: Alex Shi <alex.shi@intel.com>
>> >>>> ---
>> >>>> net/netfilter/xt_TEE.c | 12 ++++++------
>> >>>> net/socket.c | 4 ++--
>> >>>> 2 files changed, 8 insertions(+), 8 deletions(-)
>> >>>
>> >>> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>> >>>
>> >>> Thanks !
>> >>
>> >> Anyone like to pick up this patch? or more comments for this?
>> >
>> > Kaber, David:
>> > I appreciate for your any comments on this. Could you like do me a
>> > favor?
>>
>> No objections from me.
>
> rend this patch for 3.2.0 kernel with Eric's Ack.
>
> David, do you have any concerns for this patch? I will very appreciate
> if it can met 3.3 open window.
Please just submit it directly with the other this_cpu() patches:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2012-01-11 9:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 9:10 [PATCH] Code clean up for percpu_xxx() functions Alex,Shi
2011-10-10 17:08 ` Christoph Lameter
2011-10-11 9:19 ` Alex,Shi
2011-10-11 14:13 ` Christoph Lameter
2011-10-12 1:29 ` Alex,Shi
2011-10-12 13:59 ` Christoph Lameter
2011-10-12 14:11 ` Alex,Shi
2011-10-12 14:11 ` Christoph Lameter
2011-10-18 3:21 ` Alex,Shi
2011-10-18 14:33 ` Christoph Lameter
2011-10-19 9:23 ` Alex,Shi
2011-10-19 9:26 ` Avi Kivity
2011-10-20 2:45 ` Alex,Shi
2011-10-20 7:34 ` [PATCH 2/3] kvm: use this_cpu_xxx replace percpu_xxx funcs Alex,Shi
2011-10-24 2:50 ` Alex,Shi
2011-10-24 11:05 ` Avi Kivity
2011-11-21 9:02 ` Alex,Shi
2011-11-21 9:20 ` Avi Kivity
2011-11-21 9:52 ` Alex,Shi
2012-01-11 8:48 ` Alex,Shi
2011-10-19 15:34 ` [PATCH] Code clean up for percpu_xxx() functions Christoph Lameter
2011-10-20 2:44 ` Alex,Shi
2011-10-20 5:08 ` Eric Dumazet
2011-10-20 6:04 ` Alex,Shi
2011-10-20 6:13 ` Alex,Shi
2011-10-20 6:04 ` Alex,Shi
2011-10-20 7:20 ` [PATCH 0/3] code clean and optimzed for percpu_xxx serials funcs Alex,Shi
2011-10-20 7:32 ` [PATCH 1/3] net: use this_cpu_xxx replace percpu_xxx funcs Alex,Shi
2011-10-20 8:38 ` Eric Dumazet
2011-11-21 9:00 ` Alex,Shi
2011-12-02 2:33 ` Alex,Shi
2011-12-02 11:56 ` Patrick McHardy
2012-01-11 8:45 ` Alex,Shi
2012-01-11 9:03 ` David Miller [this message]
2012-01-11 9:10 ` Alex,Shi
2011-10-20 7:35 ` [PATCH 3/3] Code clean up for percpu_xxx() functions Alex,Shi
2011-11-21 9:10 ` Alex,Shi
2011-11-22 0:06 ` tj
2012-01-11 9:08 ` Alex,Shi
2012-01-11 17:19 ` tj
2012-01-12 0:44 ` H. Peter Anvin
2012-01-12 2:05 ` Alex,Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111.010331.2039534822545257440.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=avi@redhat.com \
--cc=cl@gentwo.org \
--cc=eric.dumazet@gmail.com \
--cc=jeremy@xensource.com \
--cc=kaber@trash.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®