From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Andy Lutomirski <luto@amacapital.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
linux-kernel@vger.kernel.org, Dan Carpenter <error27@gmail.com>
Subject: [PATCH] x86: Get rid of 'dubious one-bit signed bitfield' sprase warning
Date: Wed, 11 Jan 2012 05:11:46 +0400 [thread overview]
Message-ID: <20120111011146.GA30428@oksana.dev.rtsoft.ru> (raw)
This very noisy sparse warning appears on almost every file in the
kernel:
CHECK init/main.c
arch/x86/include/asm/thread_info.h:43:55: error: dubious one-bit signed bitfield
arch/x86/include/asm/thread_info.h:44:46: error: dubious one-bit signed bitfield
This patch changes sig_on_uaccess_error and uaccess_err flags to unsigned
type and thus fixes the warning.
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
---
Not sure why this warning is still there, as it spams the build process
a lot. I googled some discussion dated month ago... but no one sent a
patch?
http://www.spinics.net/lists/linux-kernel-janitors/msg10172.html
I went safest way, i.e. changing types to unsigned instead of bool/__u8.
arch/x86/include/asm/thread_info.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
index 7404715..bc817cd 100644
--- a/arch/x86/include/asm/thread_info.h
+++ b/arch/x86/include/asm/thread_info.h
@@ -40,8 +40,8 @@ struct thread_info {
*/
__u8 supervisor_stack[0];
#endif
- int sig_on_uaccess_error:1;
- int uaccess_err:1; /* uaccess failed */
+ unsigned int sig_on_uaccess_error:1;
+ unsigned int uaccess_err:1; /* uaccess failed */
};
#define INIT_THREAD_INFO(tsk) \
--
1.7.7.3
next reply other threads:[~2012-01-11 1:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 1:11 Anton Vorontsov [this message]
2012-01-12 15:53 ` Andy Lutomirski
2012-01-16 9:04 ` [tip:x86/urgent] x86: Get rid of dubious one-bit signed bitfield tip-bot for Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111011146.GA30428@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=error27@gmail.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome