From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757466Ab2AKKtt (ORCPT ); Wed, 11 Jan 2012 05:49:49 -0500 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:38353 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678Ab2AKKtr (ORCPT ); Wed, 11 Jan 2012 05:49:47 -0500 Date: Wed, 11 Jan 2012 05:49:40 -0500 From: Christoph Hellwig To: James Bottomley Cc: "Nicholas A. Bellinger" , Bart Van Assche , Linus Torvalds , target-devel , linux-scsi , LKML , Christoph Hellwig , Roland Dreier , J?rn Engel , Sebastian Andrzej Siewior Subject: Re: [GIT PULL] target: Updates for v3.3-rc1 (round 1) Message-ID: <20120111104940.GA5394@infradead.org> References: <1326221809.14089.23.camel@haakon2.linux-iscsi.org> <1326223998.14089.26.camel@haakon2.linux-iscsi.org> <1326225067.3264.51.camel@dabdike.int.hansenpartnership.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1326225067.3264.51.camel@dabdike.int.hansenpartnership.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 10, 2012 at 01:51:07PM -0600, James Bottomley wrote: > > The changes since the Nov 4 RFC are listed in the patch commit log: > > > > ib_srpt: Make compilation with BUG=n proceed` > > ib_srpt: Use new target_core_fabric.h include > > ib_srpt: Check hex2bin() return code to silence build warning > > > > These are all very minor and did not warrant another full RFC posting. > > They might not warrant a full RFC reposting, but individually they > should have been posted to the list, so Bart is right. At least 2 and 3 list, just not as global patches against the target tree, not ib_srpt specificly: 2 is from: [PATCH] target: header reshuffle, part2 3 is from: [PATCH 5/5] target: check hex2bin result Not sure about 1. I'm really getting tired of this bickering. It's a brand new driver and doesn't have to be perfect. While Bart generally has technically good points there's really no reason to put his remaining fixups in after the driver has been merged and available to a wieder audience.