From: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
To: Nadav Amit <namit@cs.technion.ac.il>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Nadav Amit <nadav.amit@gmail.com>
Subject: Re: [PATCH 1/2] KVM: Exception during emulation decode should propagate
Date: Thu, 12 Jan 2012 07:11:37 +0900 [thread overview]
Message-ID: <20120112071137.303628cea69b79868956d860@gmail.com> (raw)
In-Reply-To: <1326300811-17065-1-git-send-email-namit@cs.technion.ac.il>
On Wed, 11 Jan 2012 18:53:30 +0200
Nadav Amit <namit@cs.technion.ac.il> wrote:
> An exception might occur during decode (e.g., #PF during fetch).
> Currently, the exception is ignored and emulation is performed.
When I cleaned up insn_fetch(), I thought that fetching the instruction
which is being executed by the guest cannot cause #PF.
The possibility that a meaningless userspace might similtaneously unmap
the page, noted by Avi IIRC, was ignored intentionally, so we just fail
in such a case.
Did you see any real problem?
Takuya
> Instead, emulation should be skipped and the fault should be injected.
> Skipping instruction should report a failure in this case.
next prev parent reply other threads:[~2012-01-11 22:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 16:53 Nadav Amit
2012-01-11 16:53 ` [PATCH 2/2] KVM: Fix writeback on page boundary that propagate changes in spite of #PF Nadav Amit
2012-01-12 10:12 ` Gleb Natapov
2012-01-12 10:21 ` Avi Kivity
2012-01-12 10:27 ` Gleb Natapov
2012-01-14 18:27 ` Nadav Amit
2012-01-11 22:11 ` Takuya Yoshikawa [this message]
2012-01-12 0:26 ` [PATCH 1/2] KVM: Exception during emulation decode should propagate Takuya Yoshikawa
2012-01-12 9:07 ` Nadav Amit
2012-01-12 9:14 ` Takuya Yoshikawa
2012-01-12 10:16 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112071137.303628cea69b79868956d860@gmail.com \
--to=takuya.yoshikawa@gmail.com \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=namit@cs.technion.ac.il \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®