From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753084Ab2ALMf6 (ORCPT ); Thu, 12 Jan 2012 07:35:58 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56683 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556Ab2ALMf5 (ORCPT ); Thu, 12 Jan 2012 07:35:57 -0500 Date: Thu, 12 Jan 2012 13:35:55 +0100 From: Michal Hocko To: Mel Gorman Cc: KAMEZAWA Hiroyuki , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Andrea Arcangeli Subject: Re: [PATCH] mm: __count_immobile_pages make sure the node is online Message-ID: <20120112123555.GF1042@tiehlicka.suse.cz> References: <1326213022-11761-1-git-send-email-mhocko@suse.cz> <20120111084802.GA16466@tiehlicka.suse.cz> <20120112111702.3b7f2fa2.kamezawa.hiroyu@jp.fujitsu.com> <20120112082722.GB1042@tiehlicka.suse.cz> <20120112173536.db529713.kamezawa.hiroyu@jp.fujitsu.com> <20120112092314.GC1042@tiehlicka.suse.cz> <20120112183323.1bb62f4d.kamezawa.hiroyu@jp.fujitsu.com> <20120112100521.GD1042@tiehlicka.suse.cz> <20120112111415.GH4118@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120112111415.GH4118@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 12-01-12 11:14:15, Mel Gorman wrote: > On Thu, Jan 12, 2012 at 11:05:21AM +0100, Michal Hocko wrote: > > From 39de8df13532150fc4518dad0cb3f6fd88745b8a Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Thu, 12 Jan 2012 10:19:04 +0100 > > Subject: [PATCH] mm: __count_immobile_pages make sure the node is online > > > > page_zone requires to have an online node otherwise we are accessing > > NULL NODE_DATA. This is not an issue at the moment because node_zones > > are located at the structure beginning but this might change in the > > future so better be careful about that. > > > > Signed-off-by: Michal Hocko > > Signed-off-by: KAMEZAWA Hiroyuki > > Acked-by: Mel Gorman Thanks > Be aware that this is not the version picked up by Andrew. It would > not hurt to resend as V2 with a changelog and a note saying it replaces > mm-fix-null-ptr-dereference-in-__count_immobile_pages.patch in mmotm. > This is just in case the wrong one gets merged due to this thread > getting lost in the noise of Andrew's inbox. I guess that both of them should be merged. This one as a follow up fix. That's why I made it separate and didn't repost the whole patch. The original patch is much more obvious why it fixes the issue this one is to have everything clear. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic