From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
"rpurdie@rpsys.net" <rpurdie@rpsys.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Dajun Chen <Dajun.Chen@diasemi.com>
Subject: Re: [PATCH 06/07] LEDS: LED module for DA9052/53 PMIC
Date: Tue, 17 Jan 2012 20:02:27 +0000 [thread overview]
Message-ID: <20120117200227.GC31854@sirena.org.uk> (raw)
In-Reply-To: <1326806904.3542.341.camel@dhruva>
On Tue, Jan 17, 2012 at 06:58:24PM +0530, Ashish Jangam wrote:
> + error = da9052_reg_write(led->da9052, led_reg[led->led_index],
> + led->brightness | DA9052_LED_CONT_DIM);
The device has 8 bit registers but brightness could be any 8 bit number
by default (and the driver doesn't set a maxmimum brightness that I
noticed).
> +static int __init da9052_led_init(void)
> +{
> + return platform_driver_register(&da9052_led_driver);
> +}
> +module_init(da9052_led_init);
> +
> +static void __exit da9052_led_exit(void)
> +{
> + platform_driver_unregister(&da9052_led_driver);
> +}
> +module_exit(da9052_led_exit);
Use module_platform_driver()
prev parent reply other threads:[~2012-01-17 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 13:28 Ashish Jangam
2012-01-17 20:02 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117200227.GC31854@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Dajun.Chen@diasemi.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®