From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755607Ab2AQUJS (ORCPT ); Tue, 17 Jan 2012 15:09:18 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:50848 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959Ab2AQUJR (ORCPT ); Tue, 17 Jan 2012 15:09:17 -0500 Date: Tue, 17 Jan 2012 20:10:36 +0000 From: Alan Cox To: Simon Glass Cc: LKML , Greg Kroah-Hartman , linux-serial@vger.kernel.org Subject: Re: [PATCH 3/3] serial: 8250: Add a wakeup_capable module param Message-ID: <20120117201036.6d99f98f@pyramind.ukuu.org.uk> In-Reply-To: <1326826563-32215-3-git-send-email-sjg@chromium.org> References: <1326826563-32215-1-git-send-email-sjg@chromium.org> <1326826563-32215-3-git-send-email-sjg@chromium.org> X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.8; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Jan 2012 10:56:03 -0800 Simon Glass wrote: > Since serial_core now does not make serial ports wake-up capable by > default, add a parameter to support this feature in the 8250 UART. > This is the only UART where I think this feature is useful. NAK Things should just work for users. Magic parameters is not an improvement. If its a performance problem someone needs to fix the rcu sync overhead or stop using rcu on that path. Alan