From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751244Ab2ARLCA (ORCPT ); Wed, 18 Jan 2012 06:02:00 -0500 Received: from smtp.gentoo.org ([140.211.166.183]:60879 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715Ab2ARLB7 (ORCPT ); Wed, 18 Jan 2012 06:01:59 -0500 From: Mike Frysinger Organization: wh0rd.org To: Srikar Dronamraju Subject: Re: [PATCH v9 3.2 2/9] uprobes: handle breakpoint and signal step exception. Date: Wed, 18 Jan 2012 06:01:58 -0500 User-Agent: KMail/1.13.7 (Linux/3.2.0; KDE/4.6.5; x86_64; ; ) Cc: Anton Arapov , Peter Zijlstra , Linus Torvalds , Oleg Nesterov , Ingo Molnar , Andrew Morton , LKML , "Linux-mm" , Andi Kleen , Christoph Hellwig , Steven Rostedt , Roland McGrath , Thomas Gleixner , Masami Hiramatsu , Arnaldo Carvalho de Melo , Ananth N Mavinakayanahalli , Stephen Rothwell References: <20120110114821.17610.9188.sendpatchset@srdronam.in.ibm.com> <201201180518.31407.vapier@gentoo.org> <20120118104749.GG15447@linux.vnet.ibm.com> In-Reply-To: <20120118104749.GG15447@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2658957.MnuXhHn6Sl"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201201180602.04269.vapier@gentoo.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart2658957.MnuXhHn6Sl Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On Wednesday 18 January 2012 05:47:49 Srikar Dronamraju wrote: > > On Wednesday 18 January 2012 04:02:32 Srikar Dronamraju wrote: > > > > Can we use existing SET_IP() instead of set_instruction_pointer()= ? > > >=20 > > > Oleg had already commented about this in one his uprobes reviews. > > >=20 > > > The GET_IP/SET_IP available in include/asm-generic/ptrace.h doesnt wo= rk > > > on all archs. Atleast it doesnt work on powerpc when I tried it. > >=20 > > so migrate the arches you need over to it. >=20 > One question that could be asked is why arent we using instruction_pointer > instead of GET_IP since instruction_pointer is being defined in 25 > places and with references in 120 places. i think you misunderstand the point. {G,S}ET_IP() is the glue between the= =20 arch's pt_regs struct and the public facing API. the only people who shoul= d=20 be touching those macros are the ptrace core. instruction_pointer() and=20 instruction_pointer_set() are the API that asm/ptrace.h exports to the rest= of=20 the tree. =2Dmike --nextPart2658957.MnuXhHn6Sl Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPFqasAAoJEEFjO5/oN/WBT+kP/iZ/l/OJJmqsWS/OGOmAht42 5qtjP2Yci1RXCcAmNYA+yqM2/t9Zdi330FwrsladU/DxIfM80WWhPgsasI4Lt5rR dfEi47mllDBri8d17WucrAGAtyh+CrqTgIcx4Sg6dhMdCsm80o3kX+J2y/CV/sX7 6swY7TylS/s1IYG3mxNXOmlmOUwOxpHv9Of8MKw1IWUlIXT/kw6nWkCJXE9+MfZS ya4zDQjMUxU91QZZkP7TdFVZNitUsQgHKLxiwepjLKhFfe+/uVdRN54uDEjxjzox M8fXkvhhrlT8/YS4tAix4eNCkb34f9vlTsTa1CJR1XwoY7OwvQ0aS3GlxhxJ+a7q OkpzFwdFIAm3tMsb0BfxAX8I6leeUox3C3H2Yjc3FaFbQIdMJD3OH90XSTeyfwvD 3EPvIUm41npI9Rlb63HAj1Tu5hijbxmSW6scxIgg400JytK76D+hRW32dn0Y8WwC GP+DRwXfzsUOL7KYi5aNbhfFzaptGGlIyr78K2rGXwxnFbNH/eoOLZLv2uC/XQEe G7rNLxt954EI/Qf4JgdQK3Fe1rE7EP9v7+7CUvv1sIU7RiqDQPu2Ksa7gE+0jXhv FUIE9SV8ew8IIF/0WP8a78bJ0Ey0JCroI3CI6Kk1xPLa6wjGbNCEtTiD9+cL5SWn qMvGM48OVx3LrFL48JZh =yvLq -----END PGP SIGNATURE----- --nextPart2658957.MnuXhHn6Sl--