mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Simon J. Rowe" <srowe@mose.org.uk>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] libata: blacklist NCQ on WDC WD740ADFD-00NLR4
Date: Wed, 18 Jan 2012 11:38:26 +0000	[thread overview]
Message-ID: <20120118113826.7fc60f12@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <201201181038.30271.srowe@mose.org.uk>

> Jan 16 21:17:08 gilraen kernel: ata5: SError: { UnrecovData Handshk }
> Jan 16 21:17:08 gilraen kernel: ata5.00: failed command: WRITE DMA EXT
> Jan 16 21:17:08 gilraen kernel: ata5.00: cmd 
> 35/00:68:6f:5d:9a/00:01:00:00:00/e0 tag 0 dma 184320 out
> Jan 16 21:17:08 gilraen kernel:         res 
> 50/00:00:66:5d:9a/00:00:00:00:00/e0 Emask 0x10 (ATA bus error)
> Jan 16 21:17:08 gilraen kernel: ata5.00: status: { DRDY }
> Jan 16 21:17:08 gilraen kernel: ata5: hard resetting link
> Jan 16 21:17:08 gilraen kernel: ata5: SATA link up 1.5 Gbps (SStatus 113 
> SControl 300)
> Jan 16 21:17:08 gilraen kernel: ata5.00: configured for UDMA/133
> Jan 16 21:17:08 gilraen kernel: ata5: EH complete
> 
> Googling revealed that this is often caused by faulty cabling. I moved the 
> power and SATA cables and the problem has now gone but I think the disk should 
> still be added to the blacklist,

We add things to the NCQ blacklist because we have multiple clear cases
showing NCQ problems and preferably vendor confirmation. You have neither
and as you said yourself when you fixed the cables it went away.

Your drive is report UnrecovData Handshk, and its' reporting it on a non
NCQ command in your second example. You had a cable problem.

So NAK this patch

Alan



      reply	other threads:[~2012-01-18 11:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18 10:38 Simon J. Rowe
2012-01-18 11:38 ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120118113826.7fc60f12@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srowe@mose.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®