From: Grant Likely <grant.likely@secretlab.ca>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linus.walleij@stericsson.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH V1] gpio: tps65910: Use correct offset for gpio initialization
Date: Wed, 18 Jan 2012 13:49:59 -0700 [thread overview]
Message-ID: <20120118204959.GK4223@ponder.secretlab.ca> (raw)
In-Reply-To: <1326897455-8298-1-git-send-email-ldewangan@nvidia.com>
On Wed, Jan 18, 2012 at 08:07:35PM +0530, Laxman Dewangan wrote:
> Using the correct gpio offset for setting the initial value
> of gpio when setting output direction.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Applied, thanks.
g.
> ---
> drivers/gpio/gpio-tps65910.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c
> index b9c1c29..91f45b9 100644
> --- a/drivers/gpio/gpio-tps65910.c
> +++ b/drivers/gpio/gpio-tps65910.c
> @@ -52,7 +52,7 @@ static int tps65910_gpio_output(struct gpio_chip *gc, unsigned offset,
> struct tps65910 *tps65910 = container_of(gc, struct tps65910, gpio);
>
> /* Set the initial value */
> - tps65910_gpio_set(gc, 0, value);
> + tps65910_gpio_set(gc, offset, value);
>
> return tps65910_set_bits(tps65910, TPS65910_GPIO0 + offset,
> GPIO_CFG_MASK);
> --
> 1.7.1.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2012-01-18 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 14:37 Laxman Dewangan
2012-01-18 20:49 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118204959.GK4223@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®