From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757360Ab2ASESx (ORCPT ); Wed, 18 Jan 2012 23:18:53 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:45334 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754463Ab2ASESw (ORCPT ); Wed, 18 Jan 2012 23:18:52 -0500 Date: Wed, 18 Jan 2012 20:18:56 -0800 From: Olof Johansson To: Stephen Warren Cc: Peter De Schrijver , Colin Cross , Russell King , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ARM: tegra: initialize basic system clocks Message-ID: <20120119041856.GC7145@quad.lixom.net> References: <74CDBE0F657A3D45AFBB94109FB122FF177EE3A286@HQMAIL01.nvidia.com> <1326212538-15419-1-git-send-email-pdeschrijver@nvidia.com> <74CDBE0F657A3D45AFBB94109FB122FF177EE3A404@HQMAIL01.nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF177EE3A404@HQMAIL01.nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 10, 2012 at 09:23:52AM -0800, Stephen Warren wrote: > Peter De Schrijver wrote at Tuesday, January 10, 2012 9:22 AM: > > Initialize basic system clocks and provide a auxdata table to allow some > > peripheral drivers to find their clocks. > ... > > This should fix the hang you observed when sdhci_add_host() fails. > > Yes, it does. This plus the Tegra30 clock patch series you posted stops > I2C and SDHCI drivers complaining about a lack of clocks during boot, > which is a great step forwards, even if SDHCI doesn't yet initialize > successfully. Thanks. > > This patch and the clock series: > > Tested-by: Stephen Warren > Acked-by: Stephen Warren Applied. Peter, in the future please provide at least a one-sentence description of the patch in the patch description. "ARM: tegra: enable tegra30 clock framework" had no actualy patch description body so I added a simple one. It's a trivial patch but it's a good habit to always have something there. Thanks! -Olof