From: Shawn Guo <shawn.guo@linaro.org>
To: Huang Shijie <b32955@freescale.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH resent v2 1/2] ioport : add DEFINE_RES_DMA_SIZE_NAMED macro
Date: Thu, 19 Jan 2012 16:14:29 +0800 [thread overview]
Message-ID: <20120119081427.GF2247@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1326959620-25920-2-git-send-email-b32955@freescale.com>
On Thu, Jan 19, 2012 at 03:53:39PM +0800, Huang Shijie wrote:
> Some DMA resource does have the range more then ones.
>
I'm not sure the patch is welcomed. You may want to just use
DEFINE_RES_NAMED for such cases.
Regards,
Shawn
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
> include/linux/ioport.h | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> index 9d57a71..9ea5de4 100644
> --- a/include/linux/ioport.h
> +++ b/include/linux/ioport.h
> @@ -134,8 +134,10 @@ struct resource_list {
> #define DEFINE_RES_IRQ(_irq) \
> DEFINE_RES_IRQ_NAMED((_irq), NULL)
>
> +#define DEFINE_RES_DMA_SIZE_NAMED(_dma, _size, _name) \
> + DEFINE_RES_NAMED((_dma), (_size), (_name), IORESOURCE_DMA)
> #define DEFINE_RES_DMA_NAMED(_dma, _name) \
> - DEFINE_RES_NAMED((_dma), 1, (_name), IORESOURCE_DMA)
> + DEFINE_RES_DMA_SIZE_NAMED((_dma), 1, (_name))
> #define DEFINE_RES_DMA(_dma) \
> DEFINE_RES_DMA_NAMED((_dma), NULL)
>
> --
> 1.7.0.4
next prev parent reply other threads:[~2012-01-19 8:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 7:53 [PATCH resent v2 0/2] ARM/mxs : add GPMI-NAND support for imx23/imx28 Huang Shijie
2012-01-19 7:53 ` [PATCH resent v2 1/2] ioport : add DEFINE_RES_DMA_SIZE_NAMED macro Huang Shijie
2012-01-19 8:14 ` Shawn Guo [this message]
2012-01-19 8:23 ` Huang Shijie
2012-01-19 8:27 ` Huang Shijie
2012-01-19 8:55 ` Shawn Guo
2012-02-05 11:53 ` Huang Shijie
2012-02-05 12:34 ` Russell King - ARM Linux
2012-02-05 16:22 ` Huang Shijie
2012-01-19 7:53 ` [PATCH resent v2 2/2] ARM: mxs: add GPMI-NAND support for imx23/imx28 Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119081427.GF2247@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®