From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751223Ab2ATD0m (ORCPT ); Thu, 19 Jan 2012 22:26:42 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:58771 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750702Ab2ATD0l (ORCPT ); Thu, 19 Jan 2012 22:26:41 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Fri, 20 Jan 2012 12:25:12 +0900 From: KAMEZAWA Hiroyuki To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , Michal Hocko , "hannes@cmpxchg.org" , Hugh Dickins , Ying Han Subject: [PATCH v3] memcg: remove unnecessary thp check at page stat accounting Message-Id: <20120120122512.decd06c0.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20120119161445.b3a8a9d2.kamezawa.hiroyu@jp.fujitsu.com> References: <20120119161445.b3a8a9d2.kamezawa.hiroyu@jp.fujitsu.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 3.1.1 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Updated description. == >>From a6395205d9f517af7963ff61d66efbcf1c64b2a5 Mon Sep 17 00:00:00 2001 From: KAMEZAWA Hiroyuki Date: Thu, 12 Jan 2012 16:08:33 +0900 Subject: [PATCH v3] memcg: remove unnecessary check in mem_cgroup_update_page_stat() This patch is a fix for memcg: make mem_cgroup_split_huge_fixup() more efficient Above patch removes move_lock_page_cgroup(). So, we do not have to check PageTransHuge in mem_cgroup_update_page_stat and fallback into the locked accounting because both move_account and thp split are done with compound_lock so they cannot race. The race between update vs. move is protected by mem_cgroup_stealed, PageTransHuge pages shouldn't appear in this code path currently because we are tracking only file pages at the moment but later we are planning to track also other pages (e.g. mlocked ones). Changelog: - updated description. Signed-off-by: KAMEZAWA Hiroyuki --- mm/memcontrol.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 3dbff4d..ff24520 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1867,7 +1867,7 @@ void mem_cgroup_update_page_stat(struct page *page, if (unlikely(!memcg || !PageCgroupUsed(pc))) goto out; /* pc->mem_cgroup is unstable ? */ - if (unlikely(mem_cgroup_stealed(memcg)) || PageTransHuge(page)) { + if (unlikely(mem_cgroup_stealed(memcg))) { /* take a lock against to access pc->mem_cgroup */ move_lock_page_cgroup(pc, &flags); need_unlock = true; -- 1.7.4.1