From: David Miller <davem@davemloft.net>
To: netdev@pradeepdalvi.com
Cc: joe@perches.com, netdev@vger.kernel.org, hch@lst.de,
linux-kernel@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc_skb
Date: Mon, 23 Jan 2012 14:23:55 -0500 (EST) [thread overview]
Message-ID: <20120123.142355.405932925189446350.davem@davemloft.net> (raw)
In-Reply-To: <CA+Dx6HYga9HkwzZNCXc7-q7JvV5PJ2w-QqT4p1zb+upWfn3+Ag@mail.gmail.com>
From: "Pradeep A. Dalvi" <netdev@pradeepdalvi.com>
Date: Tue, 24 Jan 2012 00:43:10 +0530
> On Tue, Jan 24, 2012 at 12:23 AM, David Miller <davem@davemloft.net> wrote:
>> From: Joe Perches <joe@perches.com>
>> Date: Mon, 23 Jan 2012 10:40:34 -0800
>>
>>> Perhaps you should break this large patch
>>> into multiple separate patches.
>>
>> Agreed, this patch is way too large especially for what is obviously
>> turning out to be a very non-trivial transformation in some cases
>> and also new patch submitters should generally avoid large patches
>> like this.
>
> Acked! Will try to separate out trivial & non-trivial changes.
> Although, still trivial changes would be big enough. And at the same
> time, splitting changes into 118 patches might turn out to be
> cumbersome for review.
We didn't say to create 118 patches, we're talking about on the
order of 4 or 5 patches.
next prev parent reply other threads:[~2012-01-23 19:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 18:28 Pradeep A. Dalvi
2012-01-23 18:40 ` Joe Perches
2012-01-23 18:53 ` David Miller
2012-01-23 19:13 ` Pradeep A. Dalvi
2012-01-23 19:23 ` David Miller [this message]
2012-01-23 19:37 ` Pradeep A. Dalvi
2012-01-23 19:19 ` Pradeep A. Dalvi
2012-01-23 19:56 ` Joe Perches
2012-01-23 20:41 ` Pradeep A. Dalvi
2012-01-23 20:46 ` Joe Perches
2012-01-23 21:15 ` Eric Dumazet
2012-01-23 21:53 ` David Miller
2012-01-23 23:04 ` Pradeep A. Dalvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123.142355.405932925189446350.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@pradeepdalvi.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®