mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
	linux-scsi@vger.kernel.org,
	target-devel <target-devel@vger.kernel.org>
Subject: linux-next: build failure after merge of the nfs tree
Date: Mon, 23 Jan 2012 11:39:49 +1100	[thread overview]
Message-ID: <20120123113949.b8d1940bb60128c5c4efeece@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2064 bytes --]

Hi Trond,

After merging the nfs tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/target/iscsi/iscsi_target_configfs.c: In function 'lio_target_call_addnptotpg':
drivers/target/iscsi/iscsi_target_configfs.c:214:3: error: implicit declaration of function 'in6_pton' [-Werror=implicit-function-declaration]
drivers/target/iscsi/iscsi_target_configfs.c:239:3: error: implicit declaration of function 'in_aton' [-Werror=implicit-function-declaration]

Presumably caused by some include file cleanup in the nfs tree (probably
commit 0b5357cfc2e6 "NFS: Remove unnecessary includes from
linux/nfs_fs_i.h").

I applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 23 Jan 2012 11:35:02 +1100
Subject: [PATCH] iscsi: in_aton needs linux/inet.h

so include it directly.

Fixes this error after a recent nfs cleanup:

drivers/target/iscsi/iscsi_target_configfs.c: In function 'lio_target_call_addnptotpg':
drivers/target/iscsi/iscsi_target_configfs.c:214:3: error: implicit declaration of function 'in6_pton' [-Werror=implicit-function-declaration]
drivers/target/iscsi/iscsi_target_configfs.c:239:3: error: implicit declaration of function 'in_aton' [-Werror=implicit-function-declaration]

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/target/iscsi/iscsi_target_configfs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs.c
index 3468caa..6b35b37 100644
--- a/drivers/target/iscsi/iscsi_target_configfs.c
+++ b/drivers/target/iscsi/iscsi_target_configfs.c
@@ -21,6 +21,7 @@
 
 #include <linux/configfs.h>
 #include <linux/export.h>
+#include <linux/inet.h>
 #include <target/target_core_base.h>
 #include <target/target_core_fabric.h>
 #include <target/target_core_fabric_configfs.h>
-- 
1.7.9.rc0.23.g7e521

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

             reply	other threads:[~2012-01-23  0:49 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-23  0:39 Stephen Rothwell [this message]
2012-01-23 18:13 ` Trond Myklebust
2012-01-23 21:10   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2024-04-04 22:53 Stephen Rothwell
2024-04-04 23:08 ` Kuniyuki Iwashima
2016-06-27  0:58 Stephen Rothwell
2016-06-27 15:44 ` Trond Myklebust
2016-06-14  0:48 Stephen Rothwell
2016-05-19  0:58 Stephen Rothwell
2016-05-19 12:06 ` Trond Myklebust
2016-05-19 17:30   ` Anna Schumaker
2016-01-08  0:14 Stephen Rothwell
2016-01-08  0:15 ` Trond Myklebust
2015-08-18  0:56 Stephen Rothwell
2015-08-19  0:05 ` Stephen Rothwell
2015-08-19  0:15   ` Drokin, Oleg
2015-08-23 23:16 ` Stephen Rothwell
2015-08-24 14:17   ` Trond Myklebust
2015-08-24 14:48     ` Oleg Drokin
2014-09-15  7:04 Stephen Rothwell
2014-09-15 17:07 ` Christoph Hellwig
2013-11-19  0:01 Stephen Rothwell
2012-10-02  0:39 Stephen Rothwell
2012-10-02  1:08 ` Myklebust, Trond
2012-05-16  2:49 Stephen Rothwell
2012-05-16 17:47 ` Myklebust, Trond
2012-03-05  0:45 Stephen Rothwell
2012-03-05  1:58 ` Myklebust, Trond
2011-05-27  2:08 Stephen Rothwell
2011-05-12  1:12 Stephen Rothwell
2011-05-12 15:11 ` Trond Myklebust
2011-03-11  0:22 Stephen Rothwell
2011-03-08  1:07 Stephen Rothwell
2011-03-08 18:58 ` Trond Myklebust
2010-10-21  0:38 Stephen Rothwell
2010-10-21 14:33 ` Trond Myklebust
2010-03-22  0:26 Stephen Rothwell
2010-03-22  9:49 ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120123113949.b8d1940bb60128c5c4efeece@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=target-devel@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®