From: Michal Marek <mmarek@suse.cz>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: linux-kbuild@vger.kernel.org,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: disable -Wmissing-field-initializers for W=1
Date: Mon, 23 Jan 2012 22:18:34 +0100 [thread overview]
Message-ID: <20120123211834.GA3981@sepie.suse.cz> (raw)
In-Reply-To: <1327290850-5405-1-git-send-email-kirill.shutemov@linux.intel.com>
On Mon, Jan 23, 2012 at 05:54:10AM +0200, Kirill A. Shutemov wrote:
> -Wmissing-field-initializers is too noisy to be useful on W=1. Let's
> move it to W=2.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> scripts/Makefile.build | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index d2b366c..1535a2f 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -62,7 +62,7 @@ endif
> ifdef KBUILD_ENABLE_EXTRA_GCC_CHECKS
> warning- := $(empty)
>
> -warning-1 := -Wextra -Wunused -Wno-unused-parameter
> +warning-1 := -Wextra -Wunused -Wno-unused-parameter -Wno-missing-field-initializers
I would use $(call cc-disable-warning, missing-field-initializers), so
that W=1 has a chance of working with gcc 3.x.
Michal
next prev parent reply other threads:[~2012-01-23 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 3:54 Kirill A. Shutemov
2012-01-23 21:18 ` Michal Marek [this message]
2012-01-24 3:10 ` Kirill A. Shutemov
2012-01-26 10:10 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123211834.GA3981@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=artem.bityutskiy@linux.intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®