From: Felipe Balbi <balbi@ti.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@suse.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH] renesas; Silence uninitialized variable report in usbhsg_recip_run_handle()
Date: Tue, 24 Jan 2012 10:11:19 +0200 [thread overview]
Message-ID: <20120124081116.GF27414@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1201162239110.16712@swampdragon.chaosbits.net>
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
On Mon, Jan 16, 2012 at 10:42:10PM +0100, Jesper Juhl wrote:
> In drivers/usb/renesas_usbhs/mod_gadget.c::usbhsg_recip_run_handle()
> the Coverity Prevent checker currently flags a warning about possibly
> uninitialized use of 'ret' i usbhsg_recip_run_handle(). It does this
> since it assumes we take one of the non-default branches in the switch
> and then subsequently take the false branch in the 'if (func)' case
> below. This exact scenario will never happen, but Coverity can't see
> that for some reason. This patch initializes 'ret' to '0' when it is
> declared which should shut up this report and won't really hurt - so
> why not? At least then it's clear that 'ret' is always initialized..
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
applied, thanks
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-01-24 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 21:42 Jesper Juhl
2012-01-24 8:11 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124081116.GF27414@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=gregkh@suse.de \
--cc=jj@chaosbits.net \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®