mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: steweg@ynet.sk
Cc: kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch v4, kernel version 3.2.1] Source mode for macvlan interface
Date: Thu, 26 Jan 2012 13:31:03 -0500 (EST)	[thread overview]
Message-ID: <20120126.133103.538010558337810138.davem@davemloft.net> (raw)
In-Reply-To: <CAGsizzLp11qzJGTYr+m49yi=2RyWTjkOzaT7d3ni0EfvPsKmHg@mail.gmail.com>

From: Štefan Gula <steweg@ynet.sk>
Date: Thu, 26 Jan 2012 12:04:50 +0100

> 2012/1/26 David Miller <davem@davemloft.net>:
>> From: Stefan Gula <steweg@ynet.sk>
>> Date: Wed, 25 Jan 2012 09:48:54 +0100 (CET)
>>
>>> +             if (vlan->mode == MACVLAN_MODE_SOURCE &&
>>> +                     vlan->mode != nla_get_u32(data[IFLA_MACVLAN_MODE]))
>>  ...
>>> +     if (data && data[IFLA_MACVLAN_MACADDR_MODE] &&
>>> +             data[IFLA_MACVLAN_MACADDR]) {
>>  ...
>>> +                             return macvlan_hash_add_sources(vlan,
>>> +                                     nla_data(data[IFLA_MACVLAN_MACADDR]));
>>  ...
>>> +                     hlist_for_each_entry_rcu(list, n,
>>> +                             &vlan->port->vlan_source_hash[i], hlist) {
>>  ...
>>> +                     hlist_for_each_entry_rcu(list, n,
>>> +                             &vlan->port->vlan_source_hash[i], hlist) {
>>
>> Line things up on subsequent lines to the column right after the
>> openning parenthesis on the previous line.
>>
>> If things are indented too deeply, you need to write helper functions.
> Just to be sure, how many "\t" symbols are ok in patches? I want to
> avoid similar thing in future.

Keep it not to far past 80 columns.

      reply	other threads:[~2012-01-26 18:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <25353423.731327481250682.JavaMail.root@5-MeO-DMT.ynet.sk>
2012-01-25  8:48 ` Stefan Gula
2012-01-26  2:38   ` David Miller
2012-01-26 11:04     ` Štefan Gula
2012-01-26 18:31       ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120126.133103.538010558337810138.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=steweg@ynet.sk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®