From: Olof Johansson <olof@lixom.net>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Colin Cross <ccross@android.com>,
Stephen Warren <swarren@nvidia.com>,
Russell King <linux@arm.linux.org.uk>,
Gary King <gking@nvidia.com>, Arnd Bergmann <arnd@arndb.de>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/8] ARM: tegra: introduce support for reading chipid
Date: Fri, 27 Jan 2012 00:19:12 -0800 [thread overview]
Message-ID: <20120127081912.GA13387@quad.lixom.net> (raw)
In-Reply-To: <1327597641-7519-2-git-send-email-pdeschrijver@nvidia.com>
Hi,
On Thu, Jan 26, 2012 at 07:07:06PM +0200, Peter De Schrijver wrote:
> Introduce a function to read the Tegra chipid. This will be used by the SMP
> code to distinguish between Tegra variants.
>
> ---
>
> Should this be merged with the fuse reading code even though this is a
> hardwired register, not a fuse based register?
Well, it's part of a register that the fuse code already reads, i.e. in
tegra_get_revision(). I'd say add it there instead of create a separate
file for it.
There's actually an opencoded version of this in that very function
already that can be cleaned up at the same time (to check for A03p vs
A03 revisions).
-Olof
next prev parent reply other threads:[~2012-01-27 8:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 17:07 [PATCH v1 0/8] Support for secondary cores on Tegra30 Peter De Schrijver
2012-01-26 17:07 ` [PATCH v1 1/8] ARM: tegra: introduce support for reading chipid Peter De Schrijver
2012-01-27 8:19 ` Olof Johansson [this message]
2012-01-26 17:07 ` [PATCH v1 2/8] ARM: tegra: functions to access the flowcontroller Peter De Schrijver
2012-01-26 17:07 ` [PATCH v1 3/8] ARM: tegra: rework Tegra secondary CPU core bringup Peter De Schrijver
2012-01-26 20:25 ` Stephen Warren
2012-01-27 8:18 ` Peter De Schrijver
2012-02-02 17:32 ` Stephen Warren
2012-01-26 17:07 ` [PATCH v1 4/8] ARM: tegra: prepare powergate.c for multiple variants Peter De Schrijver
2012-01-26 17:07 ` [PATCH v1 5/8] ARM: tegra: export tegra_powergate_is_powered() Peter De Schrijver
2012-01-26 17:07 ` [PATCH v1 6/8] ARM: tegra: add support for Tegra30 powerdomains Peter De Schrijver
2012-01-26 17:07 ` [PATCH v1 7/8] ARM: tegra: support for Tegra30 CPU powerdomains Peter De Schrijver
2012-01-26 20:40 ` Stephen Warren
2012-01-26 17:07 ` [PATCH v1 8/8] ARM: tegra: support for secondary cores on Tegra30 Peter De Schrijver
2012-01-26 20:44 ` Stephen Warren
2012-01-27 5:58 ` Murali N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127081912.GA13387@quad.lixom.net \
--to=olof@lixom.net \
--cc=arnd@arndb.de \
--cc=ccross@android.com \
--cc=gking@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pdeschrijver@nvidia.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®