From: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Indan Zupancic <indan@nul.nu>,
Youquan Song <youquan.song@intel.com>,
Ingo Molnar <mingo@elte.hu>,
Arjan van de Ven <arjan@linux.intel.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v1 1/2] sched: unified sched_powersavings sysfs tunable
Date: Fri, 27 Jan 2012 14:52:05 +0530 [thread overview]
Message-ID: <20120127092205.GC8897@dirshya.in.ibm.com> (raw)
In-Reply-To: <1327504213.2614.78.camel@laptop>
* Peter Zijlstra <a.p.zijlstra@chello.nl> [2012-01-25 16:10:13]:
> On Mon, 2012-01-16 at 21:52 +0530, Vaidyanathan Srinivasan wrote:
> > @@ -6150,10 +6150,8 @@ SD_INIT_FUNC(CPU)
> > SD_INIT_FUNC(ALLNODES)
> > SD_INIT_FUNC(NODE)
> > #endif
> > -#ifdef CONFIG_SCHED_SMT
> > +#ifdef CONFIG_SCHED_POWERSAVE
> > SD_INIT_FUNC(SIBLING)
> > -#endif
> > -#ifdef CONFIG_SCHED_MC
> > SD_INIT_FUNC(MC)
> > #endif
> > #ifdef CONFIG_SCHED_BOOK
> > @@ -6250,7 +6248,7 @@ static void claim_allocations(int cpu, struct sched_domain *sd)
> > *per_cpu_ptr(sdd->sgp, cpu) = NULL;
> > }
> >
> > -#ifdef CONFIG_SCHED_SMT
> > +#ifdef CONFIG_SCHED_POWERSAVE
> > static const struct cpumask *cpu_smt_mask(int cpu)
> > {
> > return topology_thread_cpumask(cpu);
> > @@ -6261,10 +6259,8 @@ static const struct cpumask *cpu_smt_mask(int cpu)
> > * Topology list, bottom-up.
> > */
> > static struct sched_domain_topology_level default_topology[] = {
> > -#ifdef CONFIG_SCHED_SMT
> > +#ifdef CONFIG_SCHED_POWERSAVE
> > { sd_init_SIBLING, cpu_smt_mask, },
> > -#endif
> > -#ifdef CONFIG_SCHED_MC
> > { sd_init_MC, cpu_coregroup_mask, },
> > #endif
> > #ifdef CONFIG_SCHED_BOOK
>
> I don't like this either, SCHED_{MC,SMT} here have nothing to do with
> powersavings, its topology support.
Yes, but we don't need these domains for any other purpose other than
powersave balance. The code overheads are not high, I will remove
the config option and check.
--Vaidy
next prev parent reply other threads:[~2012-01-27 9:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 16:22 [RFC PATCH v1 0/2] sched: unified sched_powersavings tunables Vaidyanathan Srinivasan
2012-01-16 16:22 ` [RFC PATCH v1 1/2] sched: unified sched_powersavings sysfs tunable Vaidyanathan Srinivasan
2012-01-25 14:53 ` Peter Zijlstra
2012-01-26 10:42 ` Jens Axboe
2012-01-26 11:08 ` Peter Zijlstra
2012-01-26 11:26 ` Jens Axboe
2012-01-26 12:04 ` Peter Zijlstra
2012-01-26 12:13 ` Jens Axboe
2012-01-26 12:39 ` Peter Zijlstra
2012-01-26 12:46 ` Jens Axboe
2012-01-28 12:06 ` [tip:sched/core] sched, block: Unify cache detection tip-bot for Peter Zijlstra
2012-01-27 9:35 ` [RFC PATCH v1 1/2] sched: unified sched_powersavings sysfs tunable Vaidyanathan Srinivasan
2012-01-25 14:57 ` Peter Zijlstra
2012-01-27 9:16 ` Vaidyanathan Srinivasan
2012-01-25 15:10 ` Peter Zijlstra
2012-01-25 15:12 ` Arjan van de Ven
2012-01-25 15:36 ` Peter Zijlstra
2012-01-27 9:22 ` Vaidyanathan Srinivasan [this message]
2012-01-27 9:40 ` Peter Zijlstra
2012-01-16 16:22 ` [RFC PATCH v1 2/2] sched: fix group_capacity for thread level consolidation Vaidyanathan Srinivasan
2012-01-25 15:38 ` Peter Zijlstra
2012-01-27 9:10 ` Vaidyanathan Srinivasan
2012-01-17 18:44 ` [RFC PATCH v1 0/2] sched: unified sched_powersavings tunables Vaidyanathan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127092205.GC8897@dirshya.in.ibm.com \
--to=svaidy@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@linux.intel.com \
--cc=indan@nul.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome