mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Tony Luck <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org, Borislav Petkov <bp@amd64.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/mce: Replace hard coded hex constants with symbolic defines
Date: Fri, 27 Jan 2012 11:49:20 +0100	[thread overview]
Message-ID: <20120127104920.GD31782@elte.hu> (raw)
In-Reply-To: <08dda402d60a721ac94e79efd7646b332be3e3b2.1327622761.git.tony.luck@intel.com>


* Tony Luck <tony.luck@intel.com> wrote:

> Magic constants like 0x0134 in code just invite questions on
> where they come from, what they mean, can they be changed?
> 
> Provide #defines for the architecturally defined MCACOD values
> with a reference to the Intel Software Developers manual which
> describes them.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> 
> Ingo: You said "ok up to 100 cols or so" ... this goes to 103.
> If this is OK, you can either apply it from here on top of the
> x86/mce branch in tip - or I can push it to the ras tree and
> send you another pull.

Yeah, looks good to me.

Thanks,

	Ingo

      reply	other threads:[~2012-01-27 10:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-24 23:06 [GIT PULL] MCE recovery changes Luck, Tony
2012-01-26 10:46 ` Ingo Molnar
2012-01-26 17:29   ` Tony Luck
2012-01-26 18:28     ` Ingo Molnar
2012-01-27  0:02       ` [PATCH] x86/mce: Replace hard coded hex constants with symbolic defines Tony Luck
2012-01-27 10:49         ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120127104920.GD31782@elte.hu \
    --to=mingo@elte.hu \
    --cc=bp@amd64.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome