From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ryan Mallon <rmallon@gmail.com>
Cc: airlied@linux.ie, airlied@redhat.com,
Alan Cox <alan@linux.intel.com>,
ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
airlied@linux.ie
Subject: Re: [RFC PATCH] gma500: Fix suspend/resume functions
Date: Fri, 27 Jan 2012 11:40:29 +0000 [thread overview]
Message-ID: <20120127114029.51c56bc6@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <4F224408.2040208@gmail.com>
On Fri, 27 Jan 2012 17:28:24 +1100
Ryan Mallon <rmallon@gmail.com> wrote:
> Both the suspend and resume functions incorrectly set psbfb =
> to_psb_fb(NULL) outside of the loop over all of the framebuffers. Fix
> this by moving the assignment of psbfb inside the loop and removing the
> initialisation of fb.
>
> Signed-off-by: Ryan Mallon <rmallon@gmail.com>
Yes that wants fixing
Acked-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2012-01-27 11:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 6:28 Ryan Mallon
2012-01-27 11:40 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127114029.51c56bc6@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=alan@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmallon@gmail.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®