Re: [PATCH] iommu/msm: Fix error handling in msm_iommu_unmap()

[Joerg Roedel <joerg.roedel@amd.com>]

On Thu, Jan 26, 2012 at 04:06:30PM -0800, David Brown wrote:
> On Thu, Jan 26, 2012 at 06:29:44PM +0100, Joerg Roedel wrote:
> > Error handling in msm_iommu_unmap() is broken. On some error
> > conditions retval is set to a non-zero value which causes
> > the function to return 'len' at the end. This hides the
> > error from the user. Zero should be returned in those error
> > cases.
> > 
> > Cc: David Brown <davidb@codeaurora.org>
> > Cc: Stepan Moskovchenko <stepanm@codeaurora.org>
> > Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> > ---
> >  drivers/iommu/msm_iommu.c |    7 +------
> >  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> Acked-by: David Brown <davidb@codeaurora.org>

Thanks. I'll queue this up with iommu fixes for 3.3 and mark it for
stable as well.


	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632