From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Arthur Taylor <art@ified.ca>, Jiri Slaby <jslaby@suse.cz>,
Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH] Fix KDFONTOP 32bit compatibility layer
Date: Sun, 29 Jan 2012 00:28:58 +0100 [thread overview]
Message-ID: <20120128232858.GA18484@type.famille.thibault.fr> (raw)
KDFONTOP(GET) currently fails with EIO when being run in a 32bit
userland with a 64bit kernel if the font width is not 8. This is because
the compatibility layer introduced by e9216651 forces the addition of
the KD_FONT_FLAG_OLD flag, which makes con_font_get return EIO in such
case. This flag should *not* be set for KDFONTOP, since it's actually
the whole point of this flag (see comment in con_font_set for instance).
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
diff --git a/drivers/tty/vt/vt_ioctl.c b/drivers/tty/vt/vt_ioctl.c
index 5e096f4..65447c5 100644
--- a/drivers/tty/vt/vt_ioctl.c
+++ b/drivers/tty/vt/vt_ioctl.c
@@ -1463,7 +1463,6 @@ compat_kdfontop_ioctl(struct compat_console_font_op __user *fontop,
if (!perm && op->op != KD_FONT_OP_GET)
return -EPERM;
op->data = compat_ptr(((struct compat_console_font_op *)op)->data);
- op->flags |= KD_FONT_FLAG_OLD;
i = con_font_op(vc, op);
if (i)
return i;
next reply other threads:[~2012-01-28 23:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 23:28 Samuel Thibault [this message]
2012-01-31 16:35 ` Arnd Bergmann
2012-01-31 19:15 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120128232858.GA18484@type.famille.thibault.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=art@ified.ca \
--cc=gregkh@suse.de \
--cc=jolsa@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®