mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests: Make run_tests executable
Date: Mon, 30 Jan 2012 15:51:05 -0800	[thread overview]
Message-ID: <20120130155105.029b02fb.akpm@linux-foundation.org> (raw)
In-Reply-To: <1327943069-28048-1-git-send-email-fweisbec@gmail.com>

On Mon, 30 Jan 2012 18:04:29 +0100
Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Make the main script that launches the tests to
> become executable. Otherwise people need to launch
> it as an argument to a new bash instance.
> 

That's a feature ;)

The x bit can easily get lost on kernel scripts.  For example, if
someone upgrades their kernel with patch(1) and the patch adds or
renames the script, the x bit gets lost.

If we were to set the x bit for the subset of people who get their
scripts direct from a git repository then those people might write and
distribute tools which fail when used by people who have lost their x
bit.  I've seen this happen at least once before.


  reply	other threads:[~2012-01-30 23:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 17:04 Frederic Weisbecker
2012-01-30 23:51 ` Andrew Morton [this message]
2012-02-01 15:24   ` Frederic Weisbecker
2012-02-01 19:54     ` Andrew Morton
2012-02-02 12:39       ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120130155105.029b02fb.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome