From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeroen Van den Keybus <jeroen.vandenkeybus@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Clemens Ladisch <clemens@ladisch.de>,
"Huang, Shane" <Shane.Huang@amd.com>,
Borislav Petkov <bp@amd64.org>,
"Nguyen, Dong" <Dong.Nguyen@amd.com>,
jesse.brandeburg@gmail.com
Subject: Re: [PATCH] Unhandled IRQs on AMD E-450: temporarily switch to low-performance polling IRQ mode
Date: Mon, 30 Jan 2012 22:04:26 +0000 [thread overview]
Message-ID: <20120130220426.4d4d48a7@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <CAPRPZsAt+e3cy1YTriikpb2SNN=jOusvnPF0ByFeun+uaBa5Og@mail.gmail.com>
> + printk("Polling IRQ %d\n", irq);
printk levels would be good.
> - __report_bad_irq(irq, desc, action_ret);
> + /* __report_bad_irq(irq, desc, action_ret); */
And this removes debugging for a reason that isn't described ?
In general this looks sane although it may do bad stuff on some platforms
I guess - notably irqpoll has an x86 ism in it still that now may need
dealing with (the IRQ 0 magic)
Alan
prev parent reply other threads:[~2012-01-30 22:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 21:37 Jeroen Van den Keybus
2012-01-30 22:04 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120130220426.4d4d48a7@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Dong.Nguyen@amd.com \
--cc=Shane.Huang@amd.com \
--cc=bp@amd64.org \
--cc=clemens@ladisch.de \
--cc=jeroen.vandenkeybus@gmail.com \
--cc=jesse.brandeburg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®