From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754144Ab2AaADW (ORCPT ); Mon, 30 Jan 2012 19:03:22 -0500 Received: from cantor2.suse.de ([195.135.220.15]:35878 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752526Ab2AaADU (ORCPT ); Mon, 30 Jan 2012 19:03:20 -0500 Date: Tue, 31 Jan 2012 01:03:19 +0100 From: Jan Kara To: Nigel Cunningham Cc: "Rafael J. Wysocki" , Jan Kara , Linux PM list , LKML , linux-fsdevel@vger.kernel.org, Dave Chinner , Pavel Machek , "Srivatsa S. Bhat" , Al Viro Subject: Re: [RFC][PATCH] PM / Sleep: Freeze filesystems during system suspend/hibernation Message-ID: <20120131000319.GH7827@quack.suse.cz> References: <201201281445.49377.rjw@sisk.pl> <20120130200040.GB7827@quack.suse.cz> <201201302205.34159.rjw@sisk.pl> <4F27074D.2040006@tuxonice.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F27074D.2040006@tuxonice.net> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 31-01-12 08:10:37, Nigel Cunningham wrote: > Hi. > > On 31/01/12 08:05, Rafael J. Wysocki wrote: > > On Monday, January 30, 2012, Jan Kara wrote: > >> On Sat 28-01-12 14:45:49, Rafael J. Wysocki wrote: > >>> + /* > >>> + * Freeze in reverse order so filesystems depending on others are > >>> + * frozen in the right order (eg. loopback on ext3). > >>> + */ > >> Ho, hum, are you sure the order in super_blocks list is the one you need? > >> Maybe it is but I'm not sure you are guaranteed it is. > > > > Well, is there any way I can get the right order? > > Jan, what's the case where the reverse of mount order might be the wrong > order? After some though, I'm not able to come up with a counterexample. As I wrote to Rafael, let's at least document that we rely on some ordering of super_blocks list. Honza -- Jan Kara SUSE Labs, CR