From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Danny Kukawka <danny.kukawka@bisect.de>
Cc: netdev@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Steve Glendinning <steve.glendinning@smsc.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Danny Kukawka <dkukawka@suse.de>
Subject: Re: [PATCH] smsc95xx: add macaddr module parameter
Date: Tue, 31 Jan 2012 17:27:31 +0000 [thread overview]
Message-ID: <20120131172731.03df5704@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1328030433-12524-1-git-send-email-danny.kukawka@bisect.de>
On Tue, 31 Jan 2012 18:20:33 +0100
Danny Kukawka <danny.kukawka@bisect.de> wrote:
> Added smsc95xx.macaddr module parameter to allow the user to
> change the MAC address on boot if there was no MAC on the EEPROM.
NAK. Please see the discussion on this and ifconfig hw for other devices.
In summary - make the device refuse to ifconfig up without a valid
address, allow it to come into existance without a valid address and then
use ifconfig.
Your patch also seems to break if there are several attached to a board.
next prev parent reply other threads:[~2012-01-31 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 17:20 Danny Kukawka
2012-01-31 17:27 ` Alan Cox [this message]
2012-01-31 18:17 ` Danny Kukawka
2012-01-31 19:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131172731.03df5704@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=danny.kukawka@bisect.de \
--cc=dkukawka@suse.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®