From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: lizf@cn.fujitsu.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
nhorman@tuxdriver.com
Subject: Re: [PATCH 6/6] cls_cgroup: remove redundant rcu_read_lock/unlock
Date: Wed, 01 Feb 2012 02:10:02 -0500 (EST) [thread overview]
Message-ID: <20120201.021002.1399660597996401402.davem@davemloft.net> (raw)
In-Reply-To: <1328080039.22641.2.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 01 Feb 2012 08:07:19 +0100
> Then, I wonder why we do the "if (classid && classid != sk->sk_classid)"
>
> before the :
>
> sk->sk_classid = classid;
>
> This seems unnecessary checks.
>
Avoiding dirtying the sk->sk_classid cache line unnecessarily?
I actually have no idea actually how often this routine can get
invoked in real world scenerios.
next prev parent reply other threads:[~2012-02-01 7:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 6:55 [PATCH 1/6] netprio_cgroup: fix an off-by-one bug Li Zefan
2012-02-01 6:55 ` [PATCH 2/6] netprio_cgroup: don't allocate prio table when a device is registered Li Zefan
2012-02-01 6:55 ` [PATCH 3/6] netprio_cgroup: fix wrong memory access when NETPRIO_CGROUP=m Li Zefan
2012-02-01 6:56 ` [PATCH 4/6] netprio_cgroup: use IS_ENABLED() and family Li Zefan
2012-02-01 6:59 ` David Miller
2012-02-01 7:06 ` Li Zefan
2012-02-01 7:07 ` David Miller
2012-02-01 7:22 ` Li Zefan
2012-02-01 12:02 ` Neil Horman
2012-02-01 6:56 ` [PATCH 5/6] cls_cgroup: " Li Zefan
2012-02-01 6:56 ` [PATCH 6/6] cls_cgroup: remove redundant rcu_read_lock/unlock Li Zefan
2012-02-01 7:07 ` Eric Dumazet
2012-02-01 7:10 ` David Miller [this message]
2012-02-01 7:20 ` Li Zefan
2012-02-01 7:23 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201.021002.1399660597996401402.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cgroups@vger.kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®