From: Olof Johansson <olof@lixom.net>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Colin Cross <ccross@android.com>,
Stephen Warren <swarren@nvidia.com>,
Russell King <linux@arm.linux.org.uk>,
Gary King <gking@nvidia.com>, Arnd Bergmann <arnd@arndb.de>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/8] ARM: tegra: functions to access the flowcontroller
Date: Tue, 31 Jan 2012 23:26:17 -0800 [thread overview]
Message-ID: <20120201072617.GC7399@quad.lixom.net> (raw)
In-Reply-To: <1328028051-24271-3-git-send-email-pdeschrijver@nvidia.com>
On Tue, Jan 31, 2012 at 06:40:40PM +0200, Peter De Schrijver wrote:
> Introduce some functions to write to the flowcontroller registers.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> ---
> arch/arm/mach-tegra/Makefile | 1 +
> arch/arm/mach-tegra/flowctrl.c | 62 ++++++++++++++++++++++++++++++++++++++++
> arch/arm/mach-tegra/flowctrl.h | 5 +++
> 3 files changed, 68 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/mach-tegra/flowctrl.c
>
> diff --git a/arch/arm/mach-tegra/Makefile b/arch/arm/mach-tegra/Makefile
> index b78bda8..60c286e 100644
> --- a/arch/arm/mach-tegra/Makefile
> +++ b/arch/arm/mach-tegra/Makefile
> @@ -6,6 +6,7 @@ obj-y += irq.o
> obj-y += clock.o
> obj-y += timer.o
> obj-y += fuse.o
> +obj-y += flowctrl.o
> obj-$(CONFIG_ARCH_TEGRA_2x_SOC) += powergate.o
> obj-$(CONFIG_ARCH_TEGRA_2x_SOC) += tegra2_clocks.o
> obj-$(CONFIG_ARCH_TEGRA_2x_SOC) += tegra2_emc.o
> diff --git a/arch/arm/mach-tegra/flowctrl.c b/arch/arm/mach-tegra/flowctrl.c
> new file mode 100644
> index 0000000..fef66a7
> --- /dev/null
> +++ b/arch/arm/mach-tegra/flowctrl.c
> @@ -0,0 +1,62 @@
> +/*
> + * arch/arm/mach-tegra/flowctrl.c
> + *
> + * functions and macros to control the flowcontroller
Nit:
It would be more useful here to get one or two sentences about what the flow
controller unit is used for, etc.
-Olof
next prev parent reply other threads:[~2012-02-01 7:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 16:40 [PATCH v2 0/8] Add tegra30 support for secondary cores Peter De Schrijver
2012-01-31 16:40 ` [PATCH v2 1/8] ARM: tegra: export the chipid Peter De Schrijver
2012-02-01 7:26 ` Olof Johansson
2012-01-31 16:40 ` [PATCH v2 2/8] ARM: tegra: functions to access the flowcontroller Peter De Schrijver
2012-02-01 7:26 ` Olof Johansson [this message]
2012-01-31 16:40 ` [PATCH v2 3/8] ARM: tegra: rework Tegra secondary CPU core bringup Peter De Schrijver
2012-01-31 22:50 ` Russell King - ARM Linux
2012-02-01 11:08 ` Will Deacon
2012-02-01 7:54 ` Olof Johansson
2012-02-01 10:01 ` Peter De Schrijver
2012-01-31 16:40 ` [PATCH v2 4/8] ARM: tegra: prepare powergate.c for multiple variants Peter De Schrijver
2012-01-31 16:40 ` [PATCH v2 5/8] ARM: tegra: export tegra_powergate_is_powered() Peter De Schrijver
2012-01-31 16:40 ` [PATCH v2 6/8] ARM: tegra: add support for Tegra30 powerdomains Peter De Schrijver
2012-01-31 16:40 ` [PATCH v2 7/8] ARM: tegra: support for Tegra30 CPU powerdomains Peter De Schrijver
2012-01-31 16:40 ` [PATCH v2 8/8] ARM: tegra: support for secondary cores on Tegra30 Peter De Schrijver
2012-02-02 18:04 ` Stephen Warren
2012-02-06 23:23 ` Peter De Schrijver
2012-02-02 18:17 ` Colin Cross
2012-02-01 8:33 ` [PATCH v2 0/8] Add tegra30 support for secondary cores Olof Johansson
2012-02-01 10:10 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201072617.GC7399@quad.lixom.net \
--to=olof@lixom.net \
--cc=arnd@arndb.de \
--cc=ccross@android.com \
--cc=gking@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pdeschrijver@nvidia.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome