mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Robert Richter <robert.richter@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Stephane Eranian <eranian@google.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] perf script: Add script to collect and display IBS samples
Date: Thu, 2 Feb 2012 12:21:33 +0100	[thread overview]
Message-ID: <20120202112133.GR16322@erda.amd.com> (raw)
In-Reply-To: <20111230095521.GA12077@elte.hu>

Ingo,

On 30.12.11 10:55:21, Ingo Molnar wrote:
> 
> * Robert Richter <robert.richter@amd.com> wrote:
> 
> > > Once something like 'perf report' works for some useful 
> > > looking sub-case you can also tack on all the extra IBS 
> > > goodies that specialized tools might need as well, i have no 
> > > problem with providing that.
> > 
> > Isn't that outlook I gave about pebs like implementation of 
> > the precise bit with IBS "useful enough"? This would be on top 
> > patches anyway, so no need to hold back current patches.
> 
> An 'outlook' is not something I can test before sending commits 
> to Linus.

The question was more if this is the direction you think may make
sense to go to. Of course, I would then implement and send patches for
this.

> To help your effort we could tentatively put the patches into a 
> separate tip:perf/ibs topic branch if everyone agrees otherwise, 
> which can go upstream once it's complete and usable.

This would be very helpful for me. So far I see following patches for
this on top of today's tip/perf/core (623ec99):

08e232d perf, x86: Implement IBS event configuration
05efba4 perf, x86: Implement IBS interrupt handler
b0532b2 perf, x86: Implement IBS pmu control ops
56ccf1a perf, x86: Implement 64 bit counter support for IBS
98e655c perf tool: Parse general/raw events from sysfs
aac22da perf tools: Add pmu mappings to header information
f1f062d perf script: Add script to collect and display IBS samples

Only 'perf tools: Add pmu mappings to header information' applies with
conflicts, so I could resend an updated version. This patch is also
independent from the other patches and can be applied separately.

If you wish I also can send all patches again, but they would be
unchanged anyway (except that one with the conflict).

Peter and Arnaldo,

please agree with a separate tip:perf/ibs development branch. It would
be easier to all of us because we don't have the effort of reviewing
patches again that will not change anymore.

Thanks,

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center


  reply	other threads:[~2012-02-02 11:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-15 17:23 [PATCH 0/4] perf tools: Add support for IBS Robert Richter
2011-12-15 17:23 ` [PATCH 1/4] perf tool: Parse general/raw events from sysfs Robert Richter
2011-12-21 16:52   ` Robert Richter
2012-01-02 11:07   ` Stephane Eranian
2011-12-15 17:23 ` [PATCH 2/4] perf tools: Add pmu mappings to header information Robert Richter
2011-12-15 17:23 ` [PATCH 3/4] perf script: Add generic perl handler to process events Robert Richter
2011-12-29 20:56   ` [tip:perf/core] " tip-bot for Robert Richter
2011-12-15 17:23 ` [PATCH 4/4] perf script: Add script to collect and display IBS samples Robert Richter
2011-12-15 19:19   ` David Ahern
2011-12-15 23:47     ` Robert Richter
2011-12-23 10:33   ` Ingo Molnar
2011-12-23 11:19     ` Robert Richter
2011-12-23 13:53       ` Ingo Molnar
2011-12-23 14:14         ` Peter Zijlstra
2011-12-23 14:40           ` Ingo Molnar
2011-12-23 16:17             ` Robert Richter
2011-12-23 16:39               ` Ingo Molnar
2011-12-23 16:50                 ` Robert Richter
2011-12-30  9:55                   ` Ingo Molnar
2012-02-02 11:21                     ` Robert Richter [this message]
2012-03-08 12:19                       ` Ingo Molnar
2012-03-09 11:41                         ` Robert Richter
2012-03-21 18:13                           ` Robert Richter
2012-03-22  7:51                             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120202112133.GR16322@erda.amd.com \
    --to=robert.richter@amd.com \
    --cc=acme@redhat.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome