From: Wolfram Sang <w.sang@pengutronix.de>
To: stigge@antcom.de
Cc: bangaragiri.g@nxp.com, srinivas.bakki@nxp.com,
sundarapandian.andithevar@nxp.com, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, kevin.wells@nxp.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: LPC32xx: Support for OHCI HCD
Date: Thu, 2 Feb 2012 17:41:14 +0100 [thread overview]
Message-ID: <20120202164114.GB3219@pengutronix.de> (raw)
In-Reply-To: <1328103028-20547-1-git-send-email-stigge@antcom.de>
[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]
On Wed, Feb 01, 2012 at 02:30:28PM +0100, stigge@antcom.de wrote:
> This patch adds OHCI support to the LPC32xx ARM platform
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
Okay, I asked for a patch to test USB, so thanks. It did not work for me,
sadly, so there seems to be more work needed in that area.
Yet, even formally, this patch is not ready for mainline. It touches
various subsystems in one patch (arch, usb), uses too much #ifdef and
also misses important mailing lists (usb).
May I ask if you read Documentation/development-process and/or
Documentation/SubmittingPatches? If not, please do so.
I'd suggest to work in smaller steps. Get LPC32xx build again and fix
the elementary clock issues. Then, get USB to work (for example). Then,
get the network driver accepted (for example). Also consider, that those
drivers have not just been forgotten to be posted. They usually had
issues which need to be fixed before mainlining. So, one task at a time
will help to keep focused, I think.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-02-02 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 13:30 stigge
2012-02-02 16:41 ` Wolfram Sang [this message]
2012-02-02 19:37 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202164114.GB3219@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=bangaragiri.g@nxp.com \
--cc=kevin.wells@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.bakki@nxp.com \
--cc=stigge@antcom.de \
--cc=sundarapandian.andithevar@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®