From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933240Ab2BBXbH (ORCPT ); Thu, 2 Feb 2012 18:31:07 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34308 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757597Ab2BBXbF (ORCPT ); Thu, 2 Feb 2012 18:31:05 -0500 X-Sasl-enc: CEmBB4wgFG+3C+0bqk304VUtXEXNf+9vHfj73OBDtT/3 1328225463 Date: Thu, 2 Feb 2012 15:29:36 -0800 From: Greg KH To: "K. Y. Srinivasan" Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, virtualization@lists.osdl.org, ohering@suse.com, zbr@ioremap.net, Haiyang Zhang Subject: Re: [PATCH 3/6] drivers: hv: Cleanup the kvp related state in hyperv.h Message-ID: <20120202232936.GA9614@kroah.com> References: <1327708522-26914-1-git-send-email-kys@microsoft.com> <1327708562-26964-1-git-send-email-kys@microsoft.com> <1327708562-26964-3-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1327708562-26964-3-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27, 2012 at 03:55:59PM -0800, K. Y. Srinivasan wrote: > Now cleanup the hyperv.h with regards to KVP definitions. > > Signed-off-by: K. Y. Srinivasan > Signed-off-by: Haiyang Zhang > include/linux/hyperv.h | 32 +++++++++++++++++++------------- > 1 files changed, 19 insertions(+), 13 deletions(-) > > diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h > index 7332b3f..802ece8 100644 > --- a/include/linux/hyperv.h > +++ b/include/linux/hyperv.h > @@ -137,7 +137,6 @@ struct hv_ku_msg { > > > > -#ifdef __KERNEL__ > > /* > * Registry value types. > @@ -162,29 +161,36 @@ enum hv_kvp_exchg_pool { > KVP_POOL_COUNT /* Number of pools, must be last. */ > }; > > +#ifndef __packed > +#define __packed __attribute__((packed)) > +#endif Why do this? If you are so worried about this in userspace, then just change the values below to __attribute__((packed)), like all of the other public .h files do. thanks, greg k-h