From: Greg KH <gregkh@linuxfoundation.org>
To: KY Srinivasan <kys@microsoft.com>
Cc: "gregkh@suse.de" <gregkh@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
"ohering@suse.com" <ohering@suse.com>,
"zbr@ioremap.net" <zbr@ioremap.net>,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH 3/6] drivers: hv: Cleanup the kvp related state in hyperv.h
Date: Thu, 2 Feb 2012 15:48:48 -0800 [thread overview]
Message-ID: <20120202234848.GA26647@kroah.com> (raw)
In-Reply-To: <6E21E5352C11B742B20C142EB499E0481B70927D@TK5EX14MBXC128.redmond.corp.microsoft.com>
On Thu, Feb 02, 2012 at 11:41:29PM +0000, KY Srinivasan wrote:
> > > +#ifndef __packed
> > > +#define __packed __attribute__((packed))
> > > +#endif
> >
> > Why do this?
> >
> > If you are so worried about this in userspace, then just change the
> > values below to __attribute__((packed)), like all of the other public .h
> > files do.
>
> Greg,
>
> When I ran the checkpatch script against these patches I got a warning that the
> preferred directive was to use "__packed".
Well, checkpatch is stupid sometimes.
> So, for the header file that will be
> consumed in the kernel, I chose to go with the __packed. For inclusion of this
> header file in the user space daemon, I put in this definition here. So rather
> than having numerous warnings, I now have a single warning. If you prefer,
> I can move this definition to the daemon code where it is really needed.
Please do it like all other public kernel header files do.
greg k-h
next prev parent reply other threads:[~2012-02-02 23:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 23:55 [PATCH 0000/0006] drivers: hv K. Y. Srinivasan
2012-01-27 23:55 ` [PATCH 1/6] drivers: hv: kvp: Add/cleanup connector defines K. Y. Srinivasan
2012-01-27 23:55 ` [PATCH 2/6] drivers: hv: kvp: Move the contents of hv_kvp.h to hyperv.h K. Y. Srinivasan
2012-01-27 23:55 ` [PATCH 3/6] drivers: hv: Cleanup the kvp related state in hyperv.h K. Y. Srinivasan
2012-02-02 23:29 ` Greg KH
2012-02-02 23:41 ` KY Srinivasan
2012-02-02 23:48 ` Greg KH [this message]
2012-02-03 2:39 ` Joe Perches
2012-01-27 23:56 ` [PATCH 4/6] tools: hv: Use hyperv.h to get the KVP definitions K. Y. Srinivasan
2012-01-27 23:56 ` [PATCH 5/6] drivers: hv: kvp: Cleanup the kernel/user protocol K. Y. Srinivasan
2012-01-27 23:56 ` [PATCH 6/6] drivers: hv: Increase the number of VCPUs supported in the guest K. Y. Srinivasan
2012-02-02 23:31 ` [PATCH 0000/0006] drivers: hv Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202234848.GA26647@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ohering@suse.com \
--cc=virtualization@lists.osdl.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome