mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Jesper Juhl <jj@chaosbits.net>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>,
	Tuukka Toivonen <tuukkat76@gmail.com>
Subject: Re: [PATCH] media, adp1653: Remove unneeded include of version.h from drivers/media/video/adp1653.c
Date: Sat, 4 Feb 2012 16:35:58 +0200	[thread overview]
Message-ID: <20120204143558.GA7784@valkosipuli.localdomain> (raw)
In-Reply-To: <alpine.LNX.2.00.1202022212550.16813@swampdragon.chaosbits.net>

Hi Jesper,

On Thu, Feb 02, 2012 at 10:15:06PM +0100, Jesper Juhl wrote:
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
>  drivers/media/video/adp1653.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
>   compile tested only.
> 
> diff --git a/drivers/media/video/adp1653.c b/drivers/media/video/adp1653.c
> index 12eedf4..badbdb6 100644
> --- a/drivers/media/video/adp1653.c
> +++ b/drivers/media/video/adp1653.c
> @@ -35,7 +35,6 @@
>  #include <linux/i2c.h>
>  #include <linux/module.h>
>  #include <linux/slab.h>
> -#include <linux/version.h>
>  #include <media/adp1653.h>
>  #include <media/v4l2-device.h>

Thanks for the patch! I've applied it to my tree --- plus removing extra
module.h at the same time.

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	jabber/XMPP/Gmail: sailus@retiisi.org.uk

      reply	other threads:[~2012-02-04 14:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 21:15 Jesper Juhl
2012-02-04 14:35 ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120204143558.GA7784@valkosipuli.localdomain \
    --to=sakari.ailus@iki.fi \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jj@chaosbits.net \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=sakari.ailus@maxwell.research.nokia.com \
    --cc=tuukkat76@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®