mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Stephane Eranian <eranian@google.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	Markus Trippelsdorf <markus@trippelsdorf.de>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: WARNING: at arch/x86/kernel/cpu/perf_event.c:989
Date: Mon, 6 Feb 2012 15:38:45 +0100	[thread overview]
Message-ID: <20120206143844.GA23807@elte.hu> (raw)
In-Reply-To: <CABPqkBQnDToQczbgW4dCXiu3x2ZTXjAuKS_q_hJ=28Pu_2HexQ@mail.gmail.com>


* Stephane Eranian <eranian@google.com> wrote:

> Ok, I found the problem!
> 
> it comes from perf_adjust_freq_unthr_context() vs perf_adjust_period().
> The latter can under certain condition stop and restart the event. So we
> had:
> 
>       stop()
>       if (delta > 0) {
>            perf_adjust_period() {
>                if (period > 8*...) {
>                    stop()
>                    ...
>                    start()
>                }
>            }
>        }
>        start()
> 
> Could have a double stop() and double start(), thus triggering the warning in
> x86_pmu_start().
> 
> Will post a patch shortly to fix this.

Please send a patch against tip:master (or perf/urgent), on top 
of:

  84f2b9b2edc0: perf: Remove deprecated WARN_ON_ONCE()

Note that I updated that patch to removed one more WARN_ON() 
than you originally sent - please add it back as appropriate, in 
the delta fix patch.

Thanks,

	Ingo

  parent reply	other threads:[~2012-02-06 14:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 21:17 Markus Trippelsdorf
2012-02-02 21:32 ` Markus Trippelsdorf
2012-02-02 22:22   ` Stephane Eranian
2012-02-04 13:51     ` Ingo Molnar
2012-02-04 18:09       ` Stephane Eranian
2012-02-06  9:54         ` Stephane Eranian
2012-02-06 10:12           ` Eric Dumazet
2012-02-06 10:40             ` Stephane Eranian
2012-02-06 11:11               ` Eric Dumazet
2012-02-06 14:13                 ` Stephane Eranian
2012-02-06 14:29                   ` Peter Zijlstra
2012-02-06 14:32                     ` Stephane Eranian
2012-02-06 15:02                       ` Peter Zijlstra
2012-02-06 14:38                   ` Ingo Molnar [this message]
2012-02-06 14:41                     ` Stephane Eranian
2012-02-06 15:47                       ` Ingo Molnar
2012-02-06 20:44                         ` Stephane Eranian
2012-02-06 20:58                           ` Peter Zijlstra
2012-02-06 21:25                             ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120206143844.GA23807@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=eranian@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®