From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: cbou@mail.ru, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add I2C driver for Summit Microelectronics SMB347 Battery Charger.
Date: Mon, 6 Feb 2012 17:05:28 +0000 [thread overview]
Message-ID: <20120206170528.6c74f206@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20120206163544.GO3070@opensource.wolfsonmicro.com>
On Mon, 6 Feb 2012 16:35:45 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Mon, Feb 06, 2012 at 04:24:09PM +0000, Alan Cox wrote:
> > Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
>
> > > There's quite a lot of read/modify/write cycles and...
>
> > True but they are basically all in the setup side of things so I'm not
> > sure the complexity is justified or appropriate ?
>
> I'm not sure what complexity you mean? If the interface is too
> difficult to use we should fix that but I didn't notice anything in the
> driver which should be more than a straight substitution (or deletion of
> code in the case of the debugfs file).
The API seems fine to me but you've then got to implement the
writeable/readable/volatile reg callbacks and figure out what is cachable
for the chip and specify it.
Seems like overkill for a chip you poke asynchronously during boot and
then basically let it mind its own business.
Alan
next prev parent reply other threads:[~2012-02-06 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 15:59 Alan Cox
2012-02-06 16:01 ` Mark Brown
2012-02-06 16:24 ` Alan Cox
2012-02-06 16:35 ` Mark Brown
2012-02-06 17:05 ` Alan Cox [this message]
2012-02-06 17:21 ` Mark Brown
2012-03-13 23:46 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206170528.6c74f206@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cbou@mail.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®