mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Dmitry Antipov <dmitry.antipov@linaro.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	linaro-dev@lists.linaro.org, patches@linaro.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Venkatesh Pallipadi <venki@google.com>
Subject: Re: [PATCH] sched: move CONFIG_IRQ_TIME_ACCOUNTING to common code
Date: Tue, 7 Feb 2012 09:29:07 +0100	[thread overview]
Message-ID: <20120207082907.GB12821@elte.hu> (raw)
In-Reply-To: <1328080789-18277-1-git-send-email-dmitry.antipov@linaro.org>


* Dmitry Antipov <dmitry.antipov@linaro.org> wrote:

> Since CONFIG_IRQ_TIME_ACCOUNTING is architecture-agnostic, 
> move it from x86 area to common code.
> 
> Signed-off-by: Dmitry Antipov <dmitry.antipov@linaro.org>
> ---
>  arch/x86/Kconfig  |   11 -----------
>  lib/Kconfig.debug |   11 +++++++++++
>  2 files changed, 11 insertions(+), 11 deletions(-)

That's not enough, right now on x86 this code needs special 
architecture glue, see how the noirqtime flag is used to call 
into enable_sched_clock_irqtime() after TSC init.

So if you apply your patch and boot CONFIG_IRQ_TIME_ACCOUNTING=y 
on say an ARM system, nothing will be done, because 
sched_clock_irqtime is always zero.

Thanks,

	Ingo

      parent reply	other threads:[~2012-02-07  8:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01  7:19 Dmitry Antipov
2012-02-07  7:38 ` Yong Zhang
2012-02-07  8:29 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120207082907.GB12821@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dmitry.antipov@linaro.org \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=venki@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®