From: Matthew Garrett <mjg@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux-kernel@vger.kernel.org, seiji.aguchi@hds.com, dzickus@redhat.com
Subject: Re: [PATCH] kmsg_dump: Don't run on non-error paths by default
Date: Wed, 8 Feb 2012 16:37:20 +0000 [thread overview]
Message-ID: <20120208163720.GB3322@srcf.ucam.org> (raw)
In-Reply-To: <20120208163007.GA19323@redhat.com>
On Wed, Feb 08, 2012 at 11:30:07AM -0500, Vivek Goyal wrote:
> > + if (reason > KMSG_DUMP_PANIC && !always_kmsg_dump)
> > + return;
>
> Did you mean reason > KMSG_DUMP_OOPS to enable oops logging by default?
Bah. Yes, I think my test system was set to panic on oops so I didn't
catch that.
> Given the fact that not everybody likes kmsg_dump() and it is not known
> how stable it with various backends, will it make sense to keep it disabled
> by default and provide a knob to enable it (instead of always_kmsg_dump).
I think logging panics and oopses by default is a useful feature. It may
be desirable to have a mechanism to disable it if some other way of
handling that (serial console, kdump) is available.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-02-08 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 16:14 Matthew Garrett
2012-02-08 16:30 ` Vivek Goyal
2012-02-08 16:37 ` Matthew Garrett [this message]
2012-02-08 16:44 ` Vivek Goyal
2012-02-08 20:24 ` Seiji Aguchi
[not found] ` <32727E9A83EE9A42A1F0906295A3A77B2E598C0A2F@USINDEVS01.corp.hds.com>
2012-02-08 20:26 ` Seiji Aguchi
2012-02-10 15:11 Matthew Garrett
2012-02-10 15:36 ` Jack Stone
2012-02-10 15:44 ` Matthew Garrett
2012-02-10 15:44 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208163720.GB3322@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seiji.aguchi@hds.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome