mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: paul.gortmaker@windriver.com
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: 8250 move broke the build on sparc
Date: Thu, 09 Feb 2012 17:48:17 -0500 (EST)	[thread overview]
Message-ID: <20120209.174817.1772850235758472350.davem@davemloft.net> (raw)
In-Reply-To: <4F344A85.4070005@windriver.com>

From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Thu, 9 Feb 2012 17:36:53 -0500

> It only uses suncore.h for sunserial_register_minors (and unreg).
> Would you like it better if I killed all ifdefs and the include
> and used an incantation of weak instead?  Might be cleaner....

It's the "../" that's ugly, not the include and usage itself.

If it's now going to be included from multiple dirs, we should
probably move it to include/linux/sunserialcore.h or similar.

  reply	other threads:[~2012-02-09 22:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 21:30 David Miller
2012-02-09 21:40 ` Stephen Rothwell
2012-02-09 21:54   ` Greg KH
2012-02-09 22:36 ` Paul Gortmaker
2012-02-09 22:48   ` David Miller [this message]
2012-02-09 23:48     ` Paul Gortmaker
2012-02-10  0:08       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120209.174817.1772850235758472350.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®