From: Felipe Balbi <balbi@ti.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Tomoya MORINAGA <tomoya.rohm@gmail.com>,
Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com
Subject: Re: [PATCH 3/3] pch_udc: Specifies GPI port number at configuration.
Date: Thu, 9 Feb 2012 09:56:30 +0200 [thread overview]
Message-ID: <20120209075629.GJ1121@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <4F2BBBDA.90900@mvista.com>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Fri, Feb 03, 2012 at 02:50:02PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 03-02-2012 11:14, Tomoya MORINAGA wrote:
>
> >Problem:
> > The GPIO ports used for detecting VBUS may be different
> > on each platform.
> > This should be easily modifiable.
> >Solution:
> > In configuration, GPI port number is specified.
>
> Isn't it better to pass this with driver's platform data.
Yes, please re-factor this port. This doesn't fit as a compile-time
choice.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-09 7:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 7:14 [PATCH 1/3] pch_udc: Detecting VBUS through GPIO Tomoya MORINAGA
2012-02-03 7:14 ` [PATCH 2/3] pch_udc: Detecting VBUS through GPIO with interrupt Tomoya MORINAGA
2012-02-09 7:58 ` Felipe Balbi
2012-02-09 7:59 ` Felipe Balbi
2012-02-03 7:14 ` [PATCH 3/3] pch_udc: Specifies GPI port number at configuration Tomoya MORINAGA
2012-02-03 10:50 ` Sergei Shtylyov
2012-02-09 7:56 ` Felipe Balbi [this message]
2012-02-21 0:27 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209075629.GJ1121@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=gregkh@suse.de \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sshtylyov@mvista.com \
--cc=tomoya.rohm@gmail.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®