From: Sascha Hauer <s.hauer@pengutronix.de>
To: Javier Martin <javier.martin@vista-silicon.com>
Cc: linux-kernel@vger.kernel.org, dan.j.williams@intel.com,
vinod.koul@intel.com, linux-arm-kernel@lists.infradead.org,
linux@arm.linux.org.uk, kernel@pengutronix.de
Subject: Re: [PATCH 1/2] i.MX DMA: Add support for 2D transfers.
Date: Thu, 9 Feb 2012 15:17:03 +0100 [thread overview]
Message-ID: <20120209141703.GB3852@pengutronix.de> (raw)
In-Reply-To: <1328285474-26365-1-git-send-email-javier.martin@vista-silicon.com>
On Fri, Feb 03, 2012 at 05:11:13PM +0100, Javier Martin wrote:
> DMAC present in i.MX2 and i.MX1 chips have two
> 2D configuration slots that any DMA channel can
> use to make 2D DMA transfers.
>
> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
My problem with this patch is that it adds new code to
arch/arm/mach-imx/dma-v1.c.
The original intention of having a legacy driver in arch/arm/mach-imx/dma-v1.c
and a dmaengine driver in drivers/dma was that we move remove the
arch/arm parts to drivers/dma once all users have switched to the new
API. I fixed the sound drivers and the mxcmmc driver already. We
currently have the imxmmc driver and the i.MX1/2 camera drivers left
in the tree. The imxmmc driver is broken for ages and I think we can
remove it when nobody takes care of putting it back to work. You seem to
work on the i.MX2 camera driver and thus you should be able to fix it
(do you use DMA here or the EMMA engine?). This leaves the i.MX1 driver
and I have no possibility to fix it. I once pinged Paulius about this
issue but appearently nothing has happened.
I think we should start cleaning this up even if we risk breaking
something. Otherwise we are stuck with the legacy driver forever.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-02-09 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 16:11 Javier Martin
2012-02-03 16:11 ` [PATCH 2/2] dmaengine: i.MX: Add support for interleaved transfers Javier Martin
2012-02-09 14:17 ` Sascha Hauer [this message]
2012-02-09 15:45 ` [PATCH 1/2] i.MX DMA: Add support for 2D transfers javier Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209141703.GB3852@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=dan.j.williams@intel.com \
--cc=javier.martin@vista-silicon.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®